Skip to content

adguardhome: add enabled option#29261

Closed
smallprogram wants to merge 1 commit into
openwrt:masterfrom
smallprogram:adguardhome
Closed

adguardhome: add enabled option#29261
smallprogram wants to merge 1 commit into
openwrt:masterfrom
smallprogram:adguardhome

Conversation

@smallprogram
Copy link
Copy Markdown
Contributor

📦 Package Details

Maintainer: @GeorgeSapkin
(You can find this by checking the history of the package Makefile.)

Description:

adguardhome: add enabled option

Related PR: openwrt/luci#8590


🧪 Run Testing Details

  • OpenWrt Version: OpenWrt 25.12
  • OpenWrt Target/Subtarget: X86/64
  • OpenWrt Device: QEUM

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

Signed-off-by: David Mandy <smallprogramzhusir@gmail.com>

Co-authored-by: Tianling Shen <cnsztl@immortalwrt.org>
@GeorgeSapkin
Copy link
Copy Markdown
Member

You are not following the contribution guidelines again, wrt commit message, cherry-picking to stable, and package release bumping.

This goes for LuCI PRs as well.

I've told you in the LuCI PR (which you have not tested against the OpenWrt packages) that it's a NACK from me, yet you still proceeded to open PRs here. It's still a NACK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants