erlang: fix PKG_CPE_ID escaping for apk ADB format#29512
Merged
Conversation
apk's ADB binary package format rejects both the backslash-escape and the percent-encoding variants of the previous CPE id: cpe:/a:erlang:erlang\/otp ERROR: info field 'tags' has invalid value cpe:/a:erlang:erlang%2Fotp ERROR: info field 'tags' has invalid value apk's tag value parser only accepts a restricted alphabet for ADB package format and neither '\' nor '%' make the cut. The result is that the package never produces an .apk. Drop the '/otp' suffix entirely and use cpe:/a:erlang:erlang, which matches the higher-level Erlang CPE entry. cve scanners that walked the more specific erlang\/otp entry will fall back to this one. This effectively reverts the product portion of bfdf014 ("lang/erlang: fix PKG_CPE_ID"), which was correct against the NIST 2.3 string but incompatible with apk's tag parser. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
Description:
apk's ADB binary package format rejects both the backslash-escape and the percent-encoding variants of the previous CPE id:
cpe:/a:erlang:erlang/otp ERROR: info field 'tags' has invalid value
cpe:/a:erlang:erlang%2Fotp ERROR: info field 'tags' has invalid value
apk's tag value parser only accepts a restricted alphabet for ADB package format and neither '' nor '%' make the cut. The result is that the package never produces an .apk.
Drop the '/otp' suffix entirely and use cpe:/a:erlang:erlang, which matches the higher-level Erlang CPE entry. cve scanners that walked the more specific erlang/otp entry will fall back to this one.
This effectively reverts the product portion of bfdf014 ("lang/erlang: fix PKG_CPE_ID"), which was correct against the NIST 2.3 string but incompatible with apk's tag parser.
🧪 Run Testing Details
✅ Formalities