luajit2: update to v2.1-20260606#29669
Conversation
|
@BKPepe does this looks right? |
|
|
||
| PKG_NAME:=luajit2 | ||
| PKG_SOURCE_DATE:=2026-02-27 | ||
| PKG_SOURCE_DATE:=2026-06-0 |
0adfaac to
c910cbc
Compare
| case "$PKG_NAME" in #luajit2 use build number at -v but releases are named by date | ||
| luajit2) | ||
| exit 0 | ||
| if /usr/bin/luajit2 -v 2>&1 | grep -q "LuaJIT 2.1."; then |
There was a problem hiding this comment.
Why do we need to specify the path? Wouldn't somthing like luajit2 -v 2>&1 | grep -q "LuaJIT 2.1." sufficient? Anyway, this seems to complicated.
What about something like this?
case "$PKG_NAME" in #luajit2 use build number at -v but releases are named by date
luajit2)
luajit2 -v 2>&1 | grep -q "LuaJIT 2.1."
;;
*)
echo "Untested package: $PKG_NAME" >&2
exit 1
;;
esacc910cbc to
e1a3ef5
Compare
| luajit2 -v 2>&1 | grep -q "LuaJIT 2.1." | ||
| ;; | ||
|
|
||
| *) |
There was a problem hiding this comment.
Since this PR bundles a test fix together with a package update, please split it into two separate commits:
a) Update luajit2.
b) Fix test-version.sh. For this commit, please ensure the commit description clearly explains the changes, include the slightly modified version comment in the code, and add the appropriate Fixes: tag.
e1a3ef5 to
affc49b
Compare
| PKG_MIRROR_HASH:=10addf4f28b09f343454d891e9f19843b338b51d33683466ffb0f2ad2882cfac | ||
| PKG_SOURCE_VERSION:=a08100e7598451d4fd3a89a9826980f7c64117e7 |
There was a problem hiding this comment.
CI/CD shows:
Hash mismatch for file luajit2-2.1.2026.06.06.tar.zst: expected 10addf4f28b09f343454d891e9f19843b338b51d33683466ffb0f2ad2882cfac, got 44a57a8bab1851e76fc345e2b99c67b9937e38aefb7941f1313539cd15219fc1
make[2]: *** [Makefile:98: /builder/dl/luajit2-2.1.2026.06.06.tar.zst] Error 1
make[2]: Leaving directory '/feed/lang/lua/luajit2'
affc49b to
0a7db9d
Compare
For changes, see tagged commit: https://github.com/openresty/luajit2/releases/tag/v2.1-20260606 Signed-off-by: Seo Suchan <tjtncks@gmail.com>
0a7db9d to
9f0889b
Compare
| case "$PKG_NAME" in #luajit2 use build number at -v but releases are named by date | ||
| luajit2) | ||
| exit 0 | ||
| luajit2 -v 2>&1 | grep -q "LuaJIT 2.1." |
There was a problem hiding this comment.
@GeorgeSapkin Sorry for the ping, could you take a look at what I might be missing here? The CI/CD output doesn't seem to print the version. If I compare it to openldap or htop, those log the version correctly. Shouldn't the test always output the visible version?
There was a problem hiding this comment.
@orangepizza try this one: grep -F "LuaJIT 2.1."
In my case, it works:
root@turris:~# luajit -v 2>&1 | grep -F "LuaJIT 2.1."
LuaJIT 2.1.0-beta3 -- Copyright (C) 2005-2017 Mike Pall. http://luajit.org/
|
Oh boy. I got it. It is caused by -q in grep. 🫨
Sorry for noise.
Dne ne 7. 6. 2026 22:39 uživatel orangepizza ***@***.***>
napsal:
… *orangepizza* left a comment (openwrt/packages#29669)
<#29669 (comment)>
@BKPepe <https://github.com/BKPepe> does this looks right?
—
Reply to this email directly, view it on GitHub
<#29669?email_source=notifications&email_token=AA7IDVFG2K74FDZX4UHWNIL46XHHFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUGQYDGMZTGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4644033311>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVDW24X7W7ZTDFJQUCL46XHHFAVCNFSM6AAAAACZ6GF42GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMNBUGAZTGMZRGE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AA7IDVD2QUAO7IC7JOYS53D46XHHFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUGQYDGMZTGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AA7IDVGOBVXX72PHZ2B7EIT46XHHFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRUGQYDGMZTGEY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
9f0889b to
793006a
Compare
|
In commit luajit2: update test-version.sh to actual test, you are missing:
|
|
have no idea what to fill fixes with: this PR itself? |
|
Like if this fixed an issus here I'd add that, but we don't have that isn't it? |
|
Have you made an issue about test version.sh cleanup? |
97b3d27 to
694f877
Compare
old just disabled version test, but as LuaJIt 2.1. part is stable. So we can use that for test if luajit2 itself able to run. Fixes: c7ca6d4 luajit2: ("add test-version.sh") Suggested-by: Josef Schlehofer <pepe.schlehofer@gmail.com> Signed-off-by: Seo Suchan <tjtncks@gmail.com>
694f877 to
aeaa219
Compare
|
Good 👍 , let's wait for CI/CD result. |
|
looks like powerpcs need some complier flag update, bug looks like riscv64 patch wasn't updated to newer code nor likely to be merged upstream |
use refreshed patch from https://github.com/openresty/luajit2/pull/236/commits patch itself is for v2.1-20260114, but it complies by SDK Signed-off-by: Seo Suchan <tjtncks@gmail.com>
as suggested in openwrt#26577 backported luajit's patch I don't have PowerPC thing so can't test if it actually works Signed-off-by: Seo Suchan <tjtncks@gmail.com>
d5f622b to
f379d22
Compare
For changes, see tagged commit:
https://github.com/openresty/luajit2/releases/tag/v2.1-20260606
added a version check that it's under 2.1.x version
📦 Package Details
Maintainer: @jmarcet
(You can find this by checking the history of the package
Makefile.)Description:
update to latest tagged version while updateing test-version.sh to check it's under 2.1.x
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.