New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-plc-utils: remove build timestamp #5213

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@lynxis
Contributor

lynxis commented Dec 3, 2017

Maintainer: @ffainelli
Compile tested: x86

Build timestamps prevent reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens lynxis@fe80.eu

@champtar champtar requested a review from ffainelli Dec 6, 2017

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 9, 2017

Contributor

ping @ffainelli

Contributor

lynxis commented Dec 9, 2017

ping @ffainelli

@ffainelli

This comment has been minimized.

Show comment
Hide comment
@ffainelli

ffainelli Dec 9, 2017

Member

LGTM, can you also submit this patch to the upstream open-plc-utils repository?

Member

ffainelli commented Dec 9, 2017

LGTM, can you also submit this patch to the upstream open-plc-utils repository?

open-plc-utils: remove build timestamp
Build timestamps prevent reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 10, 2017

Contributor

@ffainelli already did. qca/open-plc-utils#114
I've added a newline to the company field as @mhei pointed out.

Contributor

lynxis commented Dec 10, 2017

@ffainelli already did. qca/open-plc-utils#114
I've added a newline to the company field as @mhei pointed out.

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 11, 2017

Contributor

@thess can you merge it?

Contributor

lynxis commented Dec 11, 2017

@thess can you merge it?

@thess

This comment has been minimized.

Show comment
Hide comment
@thess

thess Dec 12, 2017

Member

@ffainelli is certainly an active member. I'd wait at least 7 days.
I think you have some others pending we should push with apologies and revert if requested,

Member

thess commented Dec 12, 2017

@ffainelli is certainly an active member. I'd wait at least 7 days.
I think you have some others pending we should push with apologies and revert if requested,

@ffainelli ffainelli merged commit 9491c76 into openwrt:master Dec 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ffainelli

This comment has been minimized.

Show comment
Hide comment
@ffainelli

ffainelli Dec 12, 2017

Member

Merged (still on vacation).

Member

ffainelli commented Dec 12, 2017

Merged (still on vacation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment