New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebsockets: remove build hostname #5217

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lynxis
Contributor

lynxis commented Dec 3, 2017

Maintainer: @karlp
Compile tested: x86

Using the build hostname breaks reproducible builds.

Signed-off-by: Alexander Couzens lynxis@fe80.eu

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 3, 2017

Contributor

Looks fine at first glace to me, will test it. Do you have a link to where you've filed this upstream?

Contributor

karlp commented Dec 3, 2017

Looks fine at first glace to me, will test it. Do you have a link to where you've filed this upstream?

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 4, 2017

Contributor

Was there a followup to this with upstream? They merge or respond to everything (They currently have 0 open issues and 3 open PRs)

Contributor

karlp commented Dec 4, 2017

Was there a followup to this with upstream? They merge or respond to everything (They currently have 0 open issues and 3 open PRs)

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 9, 2017

Contributor

I didn't filed it upstream yet. Feel free to do so. My plan was first get it accepted here and push it to upstream later. Sometimes the discussion on reproducible builds and removing build timestamp/hostname/.. is more complex or can take a long time e.g. a year.

Contributor

lynxis commented Dec 9, 2017

I didn't filed it upstream yet. Feel free to do so. My plan was first get it accepted here and push it to upstream later. Sometimes the discussion on reproducible builds and removing build timestamp/hostname/.. is more complex or can take a long time e.g. a year.

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 9, 2017

Contributor

Well, there's not going to be discussion if you don't even file it. I don't want to maintain this here and then get something else later. I pointed out that this project is responsive, so please do file it there so I can maintain something that will be upstreamed.

Contributor

karlp commented Dec 9, 2017

Well, there's not going to be discussion if you don't even file it. I don't want to maintain this here and then get something else later. I pointed out that this project is responsive, so please do file it there so I can maintain something that will be upstreamed.

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis
Contributor

lynxis commented Dec 9, 2017

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 10, 2017

Contributor

The patch got merged upstream and I updated the PR inlcuding the upstream patch.

Contributor

lynxis commented Dec 10, 2017

The patch got merged upstream and I updated the PR inlcuding the upstream patch.

libwebsockets: remove build hostname
Using the build hostname breaks reproducible builds.
The patch is already merged upstream

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 11, 2017

Contributor

Merged in 3531c3a

Contributor

karlp commented Dec 11, 2017

Merged in 3531c3a

@karlp karlp closed this Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment