New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: remove build timestamp #5236

Merged
merged 1 commit into from Dec 16, 2017

Conversation

Projects
None yet
2 participants
@lynxis
Contributor

lynxis commented Dec 6, 2017

Maintainer: @pprindeville
Compile tested: lantiq

Build timestamp prevents reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens lynxis@fe80.eu

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 13, 2017

Contributor
Contributor

lynxis commented Dec 13, 2017

@pprindeville

I would rename the patch, because there are several factors which might interfere with getting a reproducible build and this isn't the only one.

@pprindeville

This comment has been minimized.

Show comment
Hide comment
@pprindeville

pprindeville Dec 13, 2017

Contributor

Makes me wonder if we shouldn't have -Wdate-time as part of our TARGET_CFLAGS...

We could also set $SOURCE_DATE_EPOCH to be the mtime of the tarball... that would also be reproducible.

Contributor

pprindeville commented Dec 13, 2017

Makes me wonder if we shouldn't have -Wdate-time as part of our TARGET_CFLAGS...

We could also set $SOURCE_DATE_EPOCH to be the mtime of the tarball... that would also be reproducible.

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 14, 2017

Contributor

@pprindeville setting source_date_epoch to something meaningful is a "general" problem of the OpenWrt/LEDE build process. Atm source_date_epoch is set to the source.git timestamp, which is wrong.

Contributor

lynxis commented Dec 14, 2017

@pprindeville setting source_date_epoch to something meaningful is a "general" problem of the OpenWrt/LEDE build process. Atm source_date_epoch is set to the source.git timestamp, which is wrong.

perl: remove build timestamp
Build timestamp prevents reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 14, 2017

Contributor

renamed the patch

Contributor

lynxis commented Dec 14, 2017

renamed the patch

@pprindeville pprindeville merged commit 249127b into openwrt:master Dec 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment