New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php7: remove build timestamp #5237

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
3 participants
@lynxis
Contributor

lynxis commented Dec 6, 2017

Maintainer: @mhei
Compile tested: lantiq

Build timestamp prevents reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens lynxis@fe80.eu

@champtar champtar requested a review from mhei Dec 6, 2017

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 7, 2017

Contributor

travis runs into the 60min timelimit

Contributor

lynxis commented Dec 7, 2017

travis runs into the 60min timelimit

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 13, 2017

Contributor

ping @mhei

Contributor

lynxis commented Dec 13, 2017

ping @mhei

@pprindeville

I would change the patch name to "remove timestamp from build" or something like that, since there might be several things that impede getting a reproducible build.

@mhei

This comment has been minimized.

Show comment
Hide comment
@mhei

mhei Dec 14, 2017

Member

I will look next weekend into this. Please be patient. My only concern is that Debian also ships some patches for reproducible builds, this is what I want to cross-check. Also a new upstream version is out, so lets see whether its arleady reasoanble to update...

Member

mhei commented Dec 14, 2017

I will look next weekend into this. Please be patient. My only concern is that Debian also ships some patches for reproducible builds, this is what I want to cross-check. Also a new upstream version is out, so lets see whether its arleady reasoanble to update...

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 14, 2017

Contributor

@pprindeville debian is btw. "cheating" a little bit, because they remove some timestamps by using "strip-nondeterminism". But it's only a hack which should be removed in the future.

Contributor

lynxis commented Dec 14, 2017

@pprindeville debian is btw. "cheating" a little bit, because they remove some timestamps by using "strip-nondeterminism". But it's only a hack which should be removed in the future.

php7: remove build timestamp
Build timestamp prevents reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 14, 2017

Contributor

renamed the patch

Contributor

lynxis commented Dec 14, 2017

renamed the patch

@mhei mhei merged commit ea9a7b5 into openwrt:master Dec 15, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment