New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto: remove build time to fix reproducible builds #5241

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@lynxis
Contributor

lynxis commented Dec 7, 2017

Maintainer: @karlp
Compile tested: lantiq

Build timestamps prevents reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens lynxis@fe80.eu

mosquitto: remove build time to fix reproducible builds
Build timestamps prevents reproducible builds [0].

[0] https://reproducible-builds.org/docs/timestamps/

Signed-off-by: Alexander Couzens <lynxis@fe80.eu>

@champtar champtar requested a review from karlp Dec 7, 2017

@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Dec 7, 2017

Member

@karlp @lynxis seems there is a dependency issue

Member

champtar commented Dec 7, 2017

@karlp @lynxis seems there is a dependency issue

snprintf(buf, 1024, "mosquitto version %s", VERSION);
mqtt3_db_messages_easy_queue(&int_db, NULL, "$SYS/broker/version", 2, strlen(buf), buf, 1);
- snprintf(buf, 1024, "%s", TIMESTAMP);
+ snprintf(buf, 1024, "%s", "1970-01-01 00:00:00+0000");

This comment has been minimized.

@karlp

karlp Dec 7, 2017

Contributor

I thought you normally put in a string like "REPRODUCIBLE BUILD" not a string that looks like a broken clock?

Honestly, I think the right behaviour here is drop the publish on the next line.

@karlp

karlp Dec 7, 2017

Contributor

I thought you normally put in a string like "REPRODUCIBLE BUILD" not a string that looks like a broken clock?

Honestly, I think the right behaviour here is drop the publish on the next line.

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 7, 2017

Contributor

Have you filed this upstream? I can work there on this.

Contributor

karlp commented Dec 7, 2017

Have you filed this upstream? I can work there on this.

@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Dec 8, 2017

Member
Package libmosquittopp is missing dependencies for the following libraries:
libmosquitto.so.1
Member

champtar commented Dec 8, 2017

Package libmosquittopp is missing dependencies for the following libraries:
libmosquitto.so.1
@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 8, 2017

Contributor

That libmosquittopp issue is separate, I'll try and look at that, but it might be monday.

Contributor

karlp commented Dec 8, 2017

That libmosquittopp issue is separate, I'll try and look at that, but it might be monday.

@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Dec 8, 2017

Member

@karlp I know, just pointing it out so it's not forgotten ;)

Member

champtar commented Dec 8, 2017

@karlp I know, just pointing it out so it's not forgotten ;)

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Dec 8, 2017

Contributor

@karlp no. i'ven't yet filled this upstream.

Contributor

lynxis commented Dec 8, 2017

@karlp no. i'ven't yet filled this upstream.

@champtar

This comment has been minimized.

Show comment
Hide comment
@champtar

champtar Dec 9, 2017

Member

maybe related #4751

Member

champtar commented Dec 9, 2017

maybe related #4751

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 9, 2017

Contributor

Yep same bug, they just never got back to me with testing it.

Contributor

karlp commented Dec 9, 2017

Yep same bug, they just never got back to me with testing it.

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis
Contributor

lynxis commented Dec 10, 2017

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 11, 2017

Contributor

This pull still has the older form patch (never mind, I've pulled it from the eclipse PR)

Contributor

karlp commented Dec 11, 2017

This pull still has the older form patch (never mind, I've pulled it from the eclipse PR)

@karlp

This comment has been minimized.

Show comment
Hide comment
@karlp

karlp Dec 11, 2017

Contributor

merged in 0bc06df thanks!

Contributor

karlp commented Dec 11, 2017

merged in 0bc06df thanks!

@karlp karlp closed this Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment