New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python,python3: add support for SOURCE_DATE_EPOCH var #5303

Merged
merged 1 commit into from Dec 31, 2017

Conversation

Projects
None yet
3 participants
@commodo
Contributor

commodo commented Dec 20, 2017

Maintainer: me
Compile tested: s://github.com/lede-project/source/commits/60a39e8f5af7ed710c5c62b131fd9df6519b64e4 x86_64
Run tested: s://github.com/lede-project/source/commits/60a39e8f5af7ed710c5c62b131fd9df6519b64e4 x86_64

See:
#5278

This should make Python & Python3 packages reproducible
when building.
In my local tests, I got the same sha256 for a sample
.pyc file, so likely this is the solution that should address
this.

Signed-off-by: Alexandru Ardelean ardeleanalex@gmail.com

python,python3: add support for SOURCE_DATE_EPOCH var
See:
#5278

This should make Python & Python3 packages reproducible
when building.
In my local tests, I got the same sha256 for a sample
.pyc file, so likely this is the solution that should address
this.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
@commodo

This comment has been minimized.

Show comment
Hide comment
@commodo
Contributor

commodo commented Dec 20, 2017

@hnyman

This comment has been minimized.

Show comment
Hide comment
@hnyman

hnyman Dec 28, 2017

Contributor

ready for merge?
@commodo @lynxis

Contributor

hnyman commented Dec 28, 2017

ready for merge?
@commodo @lynxis

@commodo

This comment has been minimized.

Show comment
Hide comment
@commodo

commodo Dec 28, 2017

Contributor

hey;
nope, not ready yet
i still have to check some other distros for comparison:
see: #5278

thanks

Contributor

commodo commented Dec 28, 2017

hey;
nope, not ready yet
i still have to check some other distros for comparison:
see: #5278

thanks

@commodo

This comment has been minimized.

Show comment
Hide comment
@commodo

commodo Dec 31, 2017

Contributor

I'd say we merge this as is, and see the results on reproduce-ability here:
https://tests.reproducible-builds.org/lede/lede_ar71xx.html

And then I can try to adjust the Python packages from there

Contributor

commodo commented Dec 31, 2017

I'd say we merge this as is, and see the results on reproduce-ability here:
https://tests.reproducible-builds.org/lede/lede_ar71xx.html

And then I can try to adjust the Python packages from there

@hnyman hnyman merged commit 750f19a into openwrt:master Dec 31, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@commodo commodo deleted the commodo:python-source-date-epoch branch Dec 31, 2017

@lynxis

This comment has been minimized.

Show comment
Hide comment
@lynxis

lynxis Jan 2, 2018

Contributor

most of the python packages are fixed now.
some are still left:

mips_24kc/packages/python-base_2.7.14-6_mips_24kc.ipk (741K) is unreproducible.
mips_24kc/packages/python-cffi_1.11.2-2_mips_24kc.ipk (741K) failed to build.
mips_24kc/packages/python-cryptography_2.1.3-1_mips_24kc.ipk (261K) is unreproducible.
mips_24kc/packages/python-dev_2.7.14-6_mips_24kc.ipk (2080K) is unreproducible.
mips_24kc/packages/python-pip_9.0.1_mips_24kc.ipk (1345K) is unreproducible.
mips_24kc/packages/python3-base_3.6.4-1_mips_24kc.ipk (1118K) is unreproducible.
mips_24kc/packages/python3-cffi_1.11.2-2_mips_24kc.ipk (42K) failed to build.
mips_24kc/packages/python3-cryptography_2.1.3-1_mips_24kc.ipk (259K) is unreproducible.
mips_24kc/packages/python3-dev_3.6.4-1_mips_24kc.ipk (1590K) is unreproducible.
mips_24kc/packages/python3-light_3.6.4-1_mips_24kc.ipk (1659K) is unreproducible.
mips_24kc/packages/python3-pydoc_3.6.4-1_mips_24kc.ipk (177K) is unreproducible.
Contributor

lynxis commented Jan 2, 2018

most of the python packages are fixed now.
some are still left:

mips_24kc/packages/python-base_2.7.14-6_mips_24kc.ipk (741K) is unreproducible.
mips_24kc/packages/python-cffi_1.11.2-2_mips_24kc.ipk (741K) failed to build.
mips_24kc/packages/python-cryptography_2.1.3-1_mips_24kc.ipk (261K) is unreproducible.
mips_24kc/packages/python-dev_2.7.14-6_mips_24kc.ipk (2080K) is unreproducible.
mips_24kc/packages/python-pip_9.0.1_mips_24kc.ipk (1345K) is unreproducible.
mips_24kc/packages/python3-base_3.6.4-1_mips_24kc.ipk (1118K) is unreproducible.
mips_24kc/packages/python3-cffi_1.11.2-2_mips_24kc.ipk (42K) failed to build.
mips_24kc/packages/python3-cryptography_2.1.3-1_mips_24kc.ipk (259K) is unreproducible.
mips_24kc/packages/python3-dev_3.6.4-1_mips_24kc.ipk (1590K) is unreproducible.
mips_24kc/packages/python3-light_3.6.4-1_mips_24kc.ipk (1659K) is unreproducible.
mips_24kc/packages/python3-pydoc_3.6.4-1_mips_24kc.ipk (177K) is unreproducible.
@commodo

This comment has been minimized.

Show comment
Hide comment
@commodo

commodo Jan 2, 2018

Contributor

I don't know about you, but I'm definitely pleased with the improvement.

I will look into the rest.

Contributor

commodo commented Jan 2, 2018

I don't know about you, but I'm definitely pleased with the improvement.

I will look into the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment