New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework AICCU proto hook #579

Merged
merged 4 commits into from Dec 3, 2014

Conversation

Projects
None yet
3 participants
@oskar456
Contributor

oskar456 commented Nov 30, 2014

This should fix issue #330

Before AICCU is started, the TIC server is pinged to ensure IP connectivity and DNS resolver works. There is also a wait loop waiting for NTP stratum to go below 16.

@jow-

This comment has been minimized.

Show comment
Hide comment
@jow-

jow- Nov 30, 2014

Contributor

That will likely break for any deployment not using busybox ntpd.

Contributor

jow- commented Nov 30, 2014

That will likely break for any deployment not using busybox ntpd.

@oskar456

This comment has been minimized.

Show comment
Hide comment
@oskar456

oskar456 Nov 30, 2014

Contributor

@jow- probably. But there's possibility to disable the extrachecks by setting

option extrachecks 0
Contributor

oskar456 commented Nov 30, 2014

@jow- probably. But there's possibility to disable the extrachecks by setting

option extrachecks 0
@sbyx

This comment has been minimized.

Show comment
Hide comment
@sbyx

sbyx Dec 1, 2014

Member

Could you please change the commit titles to have "aiccu:" as prefix?

Member

sbyx commented Dec 1, 2014

Could you please change the commit titles to have "aiccu:" as prefix?

@oskar456

This comment has been minimized.

Show comment
Hide comment
@oskar456

oskar456 Dec 1, 2014

Contributor

@sbyx Sorry about that, I will fix that during rewriting the patch according to discussion in issue #330

Contributor

oskar456 commented Dec 1, 2014

@sbyx Sorry about that, I will fix that during rewriting the patch according to discussion in issue #330

oskar456 added some commits Nov 30, 2014

aiccu: Minor whitespace fix
Signed-off-by: Ondrej Caletka <Ondrej@Caletka.cz>
aiccu: add NTP sync check
This check tries to wait for NTP daemon to synchronise clock to lower stratum
than 16 before running the aiccu binary. In case timeout (configurable
in new option ntpsynctimeout; default is 90 seconds) is reached, the
AICCU is run neverrtheless. This makes the new script compliant with
some corner case scenarios like not using Busybox NTPd or not using NTPd
at all, maintaining maximum out-of-the box functionality.

Signed-off-by: Ondrej Caletka <Ondrej@Caletka.cz>
aiccu: Issue aiccu stop only when aiccu is running
When AICCU is not running, running 'aiccu stop' results in unnecessary
communications with SixXS servers.

Signed-off-by: Ondrej Caletka <Ondrej@Caletka.cz>
aiccu: Add NTP hotplug hook
This hook simply writes current stratum to /var/run/aiccu_ntp_stratum,
from where it is read by aiccu proto script.

Signed-off-by: Ondrej Caletka <Ondrej@Caletka.cz>
@oskar456

This comment has been minimized.

Show comment
Hide comment
@oskar456

oskar456 Dec 1, 2014

Contributor

I've reworked the patches to a simpler version that would be compatible with most setups. Additional waiting for NTP sync can be configured using option ntpsynctimeout, setting to 0 disables NTP sync check completely.

Contributor

oskar456 commented Dec 1, 2014

I've reworked the patches to a simpler version that would be compatible with most setups. Additional waiting for NTP sync can be configured using option ntpsynctimeout, setting to 0 disables NTP sync check completely.

@sbyx

This comment has been minimized.

Show comment
Hide comment
@sbyx

sbyx Dec 1, 2014

Member

@jow- what do you think?

Member

sbyx commented Dec 1, 2014

@jow- what do you think?

sbyx added a commit that referenced this pull request Dec 3, 2014

@sbyx sbyx merged commit c21aa25 into openwrt:master Dec 3, 2014

@oskar456 oskar456 deleted the oskar456:fix_aiccu branch Dec 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment