stubby: add missing dependency on ca-certificates #7030
Conversation
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
|
What's the process for actually getting PRs merged? I checked the wiki but couldn't find anything. It would be great if we could get some of these changes into the 18.06 branch too, if possible. |
|
Typically someone with merge rights to the repo will merge in. I believe they just periodically review new PRs. I have been super busy lately and haven't had time to address some of the recent issues/PRs for stubby and getdns. I appreciate you getting these in. |
|
Fixes issue #6682 |
|
Given the discussion around here #6682 (comment), I don't agree with merging this. If anything, the smaller @cshoredaniel I'm interested in your thoughts on the certs packages. |
|
@guidosarducci sorry for not responding sooner; life's been busy. I'd like to see ca-bundle exclusively ... there was a change on the past few months that I think may resolve the problems with path to ca-bundle not being resolved/found, so my hope is that by 19.01 release we get rid of ca-certificates. |
Using ca-bundle package saves 10KB over using ca-certificates, and with commit openwrt/openwrt@191078e83d is a drop-in replacement for packages using openssl and CA certs. This has been noted as the default in current trunk by other packages switching over e.g. openwrt@e0a5ed9f76. For further related discussion see: openwrt#7030 (comment) and openwrt#6682 (comment). Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
Signed-off-by: Tony Ambardar itugrok@yahoo.com
Maintainer: @iamperson347
Compile tested: mips_24kc, DIR-835, LEDE 17.01.5
Run tested: mips_24kc, DIR-835, LEDE 17.01.5
Description:
This separates out the ca-certificate dependency commit from PR #6707 as requested.