Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-markdown: add a new package #9224

Merged
merged 1 commit into from Jun 19, 2019
Merged

python-markdown: add a new package #9224

merged 1 commit into from Jun 19, 2019

Conversation

BKPepe
Copy link
Member

@BKPepe BKPepe commented Jun 12, 2019

Maintainer: me
Compile tested: Turris MOX, cortexa53, OpenWrt master
Run tested: Turris MOX, cortexa53, OpenWrt master with example in their documentation

Description:

About python3-setuptools dependency:
If I didn't have installed Python3 on the router and when I just installed this package, then it says:

root@turris:~# opkg install python3-markdown_3.1.1-3.7-1_aarch64_cortex-a53.ipk 
Configuring python3-base.
Configuring python3-light.
Configuring python3-markdown.
root@turris:~# python3
Python 3.7.2 (default, Jun 11 2019, 00:02:42) 
[GCC 7.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import markdown
Traceback (most recent call last):
  File "/util.py", line 98, in <module>
ModuleNotFoundError: No module named 'xml.etree.cElementTree'

Then:
AttributeError: module 'logging' has no attribute 'getLogger' as well with ModuleNotFoundError: No module named 'packaging'

Also, setuptools is mention in their setup.py as install_requires.

In any case, I would appreciate when @commodo and @jefferyto will look at it.

URL:=https://python-markdown.github.io/
DEPENDS:= \
+python3-light \
+python3-setuptools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this installs setuptools on the target;
i am not sure that is required; it seems required only during build
would removing this also work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to use pkg_resources find extensions, so it does seem to need setuptools installed at run-time. (It also uses it to normalize it's version number.)

Copy link
Member

@jefferyto jefferyto Jun 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding python3-logging as a dependency (even though it would be pulled in by python3-setuptools), since you're getting an import error and it does appear to use logging directly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't have any python3 package and install python3-setuptools it installs:
python3-base, python3-light, python3-pydoc, python3-email, python3-cgi, python3-cgitb, python3-decimal, python3-xml, python3-unittest, python3-ncurses, python3-ctypes, python3-multiprocessing- python3-codecs, python3-gdbm, python3- sqlite3, python3-logging, python3-distutils, python3-distutils, python3-openssl, python3-dbm, python3-lzma, python3-asyncio.

So yes, python3-logging it gets pulled by python3-setuptools, but I don't mind to specify there python3-logging as well.

Signed-off-by: Karel Kočí <karel.koci@nic.cz>
[Add me as maintainer]
Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
@BKPepe BKPepe merged commit cbdcca8 into openwrt:master Jun 19, 2019
@BKPepe BKPepe deleted the markdown branch July 19, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants