[RFC] package etesync and its dependencies and move luci on nginx#9736
Closed
peter-stadler wants to merge 10 commits into
Closed
[RFC] package etesync and its dependencies and move luci on nginx#9736peter-stadler wants to merge 10 commits into
peter-stadler wants to merge 10 commits into
Conversation
…, too) Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Signed-off-by: Peter Stadler <peter.stadler@student.uibk.ac.at>
Contributor
Author
|
I see that I will have to change at least the commit messages. When doing that, should I split up the changes then? If yes, how fine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: MIPS 74K, Asus RT-N16, master snapshot
Run tested: MIPS 74K, Asus RT-N16, master snapshot, run the etesync server and login to it.
Description:
I am new to contributing and I am not sure if I should split it up into more changes. Especially this proposal includes moving the luci on nginx files to the luci repository, too. See my other draft PR in luci:
openwrt/luci#2981 ([RFC] move the luci on nginx files from packages to this repository)
I would do this only if Ansuel approves it since it is his project.
You should be able to login into the admin interface at
https://routerip:44312/admin
using root both as username and as password. For production you should change thereby the password and add other user(s). You can test the android client and the web client
https://client.etesync.com/
with any user, also root. In the clients you have to set an arbitrary encryption password and the advanced setting:
https://routerip:44312.
NB: the self signed certificate is not accepted by Firefox (Chromium shows a possibility to continue “unsafe”): the admin interface and the web client will not work by default; you would have to add an exception in:
Preferences > Privacy & Security > View certificates …
The Android client allows to trust the unkown certificate (pin it in the app). Should we use acme.sh to create the ssl certificate (this needs a real domain)?
This is a first proposal and there are some points still missing:
Install etesync to another folder (instead of /etesync-server). What would be the canonical place?
Maybe add uci support and a luci app for etesync, mainly for configuring the server name; there is already a admin interface build in for user management.
Create a self-signed certificate and enable ssl in the etesync server section of the nginx configuration.Use a real domain instead of the ip as servername to make it reachable. I am not sure how to interact with the nginx configuration. Do you have any suggestions? Would it help to make it available via uci? Or would that be a bad idea or difficult?
Etesync starts a uwsgi instance; how can I restart it after an update of uwsgi? Would that be a good idea at all?
Autostart etesync by: uwsgi --ini /etc/uwsgi/sites/etesync.iniThe cleanup and preserving files on remove/update is only partial, especially: How do I remove empty folders?
I appreciate other suggestions for improvement, too. See also the topic at:
https://forum.openwrt.org/t/package-etesync-and-its-dependencies/42269
I hope it is understandable what I try to do.