Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with LibreSSL #287

Closed
wants to merge 1 commit into from
Closed

Fix build with LibreSSL #287

wants to merge 1 commit into from

Conversation

Sp1l
Copy link
Contributor

@Sp1l Sp1l commented Apr 5, 2015

No description provided.

@Sp1l
Copy link
Contributor Author

Sp1l commented Apr 5, 2015

openxpki relies on openssl version output which makes builds with LibreSSL fail. Attached patch fixes this.

@svysh
Copy link
Contributor

svysh commented Apr 6, 2015

Please allow a day or so for me to perform formal testing of openxpki with openssl vs openxpki with libressl. Gost and non-gost features.

@svysh
Copy link
Contributor

svysh commented Apr 6, 2015

openxpki-0.27 builds ok with libressl-2.1.6 and perl-5.18.4
on FreeBSD-10.1. Used a slightly hacked (skip checks of the openssl name and version, as Bernard suggested) port security/p5-openxpki. Moreover, all built-in openxpki tests pass ok.

Except GOST related openxpki tests. But let us forget about them for a while. Need to investigate this GOST issue.

Oliver, if you decide to merge the patch of Bernard, please make notice how github's tester is unhappy about it.

oliwel added a commit to oliwel/openxpki that referenced this pull request Apr 7, 2015
@oliwel
Allow compilation against LibreSSL, warn on 0.9.8 openssl version
d6605c2 
This patch includes the proposal made by pull request openxpki#287 and
allows linking agains LibreSSL. Be warned that this is not a
statement that we support LibreSSL, its fully untested! Testers and
Patches are welcome.
@oliwel
Copy link
Contributor

oliwel commented Apr 7, 2015

Thank you for the patch, it was included in d6605c2
Please note that we did no full test against LibreSSL and as we use a binding interface and call internal methods of the openssl libs chances are high that it is not working - if you can provide support in porting this code, you are welcome to join the development team.

@oliwel oliwel closed this Apr 7, 2015
@Sp1l
Copy link
Contributor Author

Sp1l commented Apr 7, 2015

I believe there was still an error in my patch, my apologies... Should have done a real one instead of adding it via Web-UI...

You should want to check the patch-version as well, hopefully no-one using OpenSSL 1.0.2 which was the first released 1.0.2.

Patch looks a lot better than my hacky one :D
Not being a user of openxpki myself I can try and help fix failures where they arise. You may want to check https://wiki.freebsd.org/LibreSSL and the sub-page with known fixes. Let me know if you find anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sp1l @svysh @oliwel