-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do *not* enforce UTF-8 #306
Conversation
Can you point to any others? There definitely were some of those in the past. |
that's what i can think of from the top of my head. also, i noticed other occurences of |
The features settings on the bpool can be simplified with Though in looking at this, I probably should submit a PR to expand the
It didn't used to be. That said,
I don't know what you mean here. xattrs are enabled by default on modern systems (because systemd wants them), and we should store them using the more efficient option, right? Setting
Unfortunately, the FHS intermingles system and user data. The trade-off here is technical correctness vs simplicity. The list expanded somewhat when Ubuntu added support in the installer and wrote zsys (which is now basically dead). I spent a lot of time discussing this with Canonical. They said they had a lot of experience with this from efforts to make Ubuntu run on mobile devices with read-only root filesystems. Many of them are optional, if you're not using the thing. Now that I'm moving away from zsys, I should perhaps separate those out (like I used to). |
encryption=aes-256-gcm is now the default. anarcat mentioned this in PR #306. Signed-off-by: Richard Laager <rlaager@wiktel.com>
|
it seems this conversation should probably be moved to a new issue / PR. :)
update: and that's #307
|
I have tried to convert a real, live workstation to ZFS and had to recreate all filesystems because of this silly settings. It actually failed to copy [source code from the supysonic project][1] (which was [eventually removed][2], but still). This commit addresses *all* such incantations I could find, but keep a reference to it in the **Hints** section or, if it's not present, the **Notes** section, mentioning it was removed and why. This is so people *can* still add it if they want. [1]: https://github.com/spl0k/supysonic/tree/270fa9883b2f2bc98f1482a68f7d9022017af50b/tests/assets/%E [2]: spl0k/supysonic#183
|
i rerolled this to include all known incantations of |
|
I'm the maintainer of the arch, NixOS, RedHat and Fedora guides (derived partially from the Debian guide) and I can not agree with the premise of this pull request. The blog post explicitly deals with existing installations and does not apply to the guides at all, which deal with new installations and therefore should be removed. New installations should enforce UTF-8, see below. UTF-8 remains desirable, because of interoperability. The fact that the problematic file path mentioned in the original description, was eventually removed speaks substance. In that pull request, the malformed UTF-8 string caused:
Therefore, I think using UTF-8 is a good default for most users. If you insist on having malformed paths in your filesystem, you can simply adjust the guide to your own needs, or creating a disk image and experiment on that instead. We are not enforcing the sensible UTF-8 default on anybody -- we only inform potential users of sensible defaults and documenting the most useful options. It is up to you to decide whether using the defaults or not. The UTF-8 option is also a particularly thorny one, in that it must be decided at pool creation time and can not be changed later. |
|
I'm going to consider this "wontfix". I understand that utf8only is not without controversy. But it's been the default in the guide for quite some time and it hasn't generated significant complaints. The Ubuntu developers didn't object to this with the installer work and it apparently hasn't generated complaints for them either. With each passing year, non-UTF-8 encoded filenames are less and less likely. I do point out the other side of this, so people can make their own choices. |
The major change for Ubuntu is to mark many of these as optional, like with Debian and the old guides. As I move away from zsys, this will end up being more like the old way. This was also discussed in #306 and #307, but this change has trade-offs. It can reduce the number of datasets created on the system, but it does so by increasing the complexity to read and follow the guide. Then I just harmonized Debian with Ubuntu. Aside from whitespace, reordering, rewording, the substantive changes were to drop /opt and add /var/lib/NetworkManager. Signed-off-by: Richard Laager <rlaager@wiktel.com>
i have tried to convert a real, live workstation to ZFS and had to recreate all filesystems because of this silly settings. It actually failed to copy source code from the supysonic project (which was eventually removed, but still). I don't think we should suggest such an advanced setting by default and, in general, I find that this guide suggests too many exotic things, instead of focusing on "just install the thing with ZFS".