Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7659 Missing thread_exit() in dmu_send.c #252

Closed
wants to merge 1 commit into from

Conversation

@lundman
Copy link

commented Nov 26, 2016

Two threads send_traverse_thread() and receive_writer_thread() should
end with thread_exit();

Mostly a cosmetic issue under IllumOS.

@ahrens

This comment has been minimized.

Copy link
Member

commented Nov 26, 2016

@ahrens ahrens added the test pass label Nov 28, 2016
@ahrens
ahrens approved these changes Nov 28, 2016
@ahrens ahrens added the reviewed label Nov 28, 2016
@pcd1193182

This comment has been minimized.

Copy link

commented Nov 28, 2016

Wow, does the threading stuff on MacOS really not automatically call thread_exit()? That's pretty unusual, AIUI. Thanks for catching that!

@ahrens

This comment has been minimized.

Copy link
Member

commented Dec 9, 2016

@lundman can you file an illumos bug for this? Then this will be ready to integrate.

@lundman lundman changed the title Missing thread_exit() in dmu_send.c 7659 Missing thread_exit() in dmu_send.c Dec 10, 2016
Two threads send_traverse_thread() and receive_writer_thread() should
end with thread_exit();

Mostly a cosmetic issue under IllumOS.
@lundman lundman force-pushed the openzfsonosx:thread_exit branch from 78387a8 to ef24e0b Dec 10, 2016
@lundman

This comment has been minimized.

Copy link
Author

commented Dec 10, 2016

Hows that :)

@ahrens

This comment has been minimized.

Copy link
Member

commented Dec 19, 2016

@ahrens ahrens closed this in a569268 Dec 20, 2016
mat813 pushed a commit to mat813/freebsd that referenced this pull request Apr 17, 2017
illumos/illumos-gate@f2c1e9b
illumos/illumos-gate@f2c1e9b

https://www.illumos.org/issues/7659
  Two threads send_traverse_thread() and receive_writer_thread() should
  end with thread_exit();
  Mostly a cosmetic issue under IllumOS.
  openzfs/openzfs#252

Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Author: Jorgen Lundman <lundman@lundman.net>


git-svn-id: https://svn.freebsd.org/base/vendor-sys/illumos/dist@316899 ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
uqs pushed a commit to freebsd/freebsd that referenced this pull request Jun 20, 2017
illumos/illumos-gate@f2c1e9b
illumos/illumos-gate@f2c1e9b

https://www.illumos.org/issues/7659
  Two threads send_traverse_thread() and receive_writer_thread() should
  end with thread_exit();
  Mostly a cosmetic issue under IllumOS.
  openzfs/openzfs#252

Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Author: Jorgen Lundman <lundman@lundman.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.