8589 zfs send | recv crashes receiving system

[waikontse]

The code is the same as the one on openzfs/zfs#6616. I just included the missing part.

[ghost]

Shouldn't this comment be updated for openzfs, describing which openzfs "versions" are affected?

[waikontse]

You're right, but how do I find out the version number? Do you use the git commit hash as version number? Or is there somewhere I can find that information?

[allanjude]

A date might be the only useful way to express this

[ahrens]

Yes, we should update the comment. The simplest change would be to say Older versions of ZFS did not handle .... If we want to be more specific, we could say Prior to the fix for bug 1234, ZFS did not handle...

[pcd1193182]

Once the comment is updated to reflect ZFS as a whole, rather than ZoL specifically, this looks good to me.

[ahrens]

Thanks for the update, @waikontse.

It looks like the indentation here is inconsistent. Each line should start with tab space asterisk.

I think that in this context "since" means "more recent than", but I think you mean "less recent than" / "older than"?

[waikontse]

Hi @ahrens, thanks for the guidance on the commenting.
I need to get used to tab spaces, I usually use spaces.

You're right, what I mean is that versions "less recent"/"older than". I'll update the formatting with the comment later today.

[prakashsurya]

In the RTI, Dan asks that code comments be updated to reflect the review feedback; see here

[ahrens]

This repo will be archived in the coming week, and therefore this PR is being closed. Alternate processes for contributing ZFS changes (including those in open PR's) include following the illumos procedures, or opening a PR against ZFSonLinux.

The reasoning behind this are outlined in an email to the developer@open-zfs.org mailing list, which is reproduced below:

The OpenZFS code repository on github (http://github.com/openzfs/openzfs) is a clone of the illumos repo, with basically identical code. The OpenZFS repo made it easier to contribute ZFS code to illumos, by leveraging the github pull request and code review processes, and by automatically building illumos and running the ZFS Test Suite.

Unfortunately, the automated systems have atrophied and we lack the effort and interest to maintain it. Meanwhile, the illumos code review and contribution process has been working well for a lot of ZFS changes (notably including ports from Linux).

Since the utility of this repo has decreased, and the volunteer workforce isn't available to maintain it, we will be archiving http://github.com/openzfs/openzfs in the coming week. Thank you to everyone who helped maintain this infrastructure, and to those who leveraged it to contribute over 500 commits to ZFS on illumos! Alternate processes for contributing ZFS changes (including those in open PR's) include following the illumos procedures, or opening a PR against ZFSonLinux.

The OpenZFS github organization (http://github.com/openzfs) will continue to exist. I will make an announcement about its future role at the OpenZFS Developer Summit on Monday.

Let me know if you have any questions,
--matt