Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs_vdev_scheduler takes newline character #3356

Closed
voidzero opened this issue Apr 28, 2015 · 3 comments
Closed

zfs_vdev_scheduler takes newline character #3356

voidzero opened this issue Apr 28, 2015 · 3 comments

Comments

@voidzero
Copy link

This is zfs 0.6.4 on a standard Linux machine. For the rest, I'll let my commands speak for itself:

# pwd
/sys/module/zfs/parameters
# cat zfs_vdev_scheduler
noop
# echo cfq > zfs_vdev_scheduler
# cat zfs_vdev_scheduler
cfq

# echo -n cfq > zfs_vdev_scheduler
# cat zfs_vdev_scheduler
cfq
# exit
@gmelikov
Copy link
Member

Close as stale.

If it's actual - feel free to reopen.

@voidzero
Copy link
Author

voidzero commented Aug 26, 2017 •
edited

Hello. This bug is still current on latest 0.6.5. I don't know how much it matters that the newline isn't trimmed but I guess it's better to make sure that it is - that it gets valid input.

@voidzero
Copy link
Author

By the way, I can't reopen this issue myself. @gmelikov @behlendorf maybe one of you can take a look?

@kernelOfTruth kernelOfTruth reopened this Aug 26, 2017
behlendorf added a commit to behlendorf/zfs that referenced this issue Aug 28, 2017
@behlendorf
Trim new line from zfs_vdev_scheduler
3aac98f 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#3356
@behlendorf behlendorf mentioned this issue Aug 28, 2017
Merged
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 15, 2018
@behlendorf @tonyhutter
Trim new line from zfs_vdev_scheduler
0d7396c 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3356 
Closes openzfs#6573
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 23, 2018
@behlendorf @tonyhutter
Trim new line from zfs_vdev_scheduler
c6be89f 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3356 
Closes openzfs#6573
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 5, 2018
@behlendorf @tonyhutter
Trim new line from zfs_vdev_scheduler
4805781 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3356 
Closes openzfs#6573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@voidzero @gmelikov @kernelOfTruth