Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctime not consistently updated for xattr updates #3644

Closed
riconnon opened this issue Jul 28, 2015 · 2 comments
Closed

ctime not consistently updated for xattr updates #3644

riconnon opened this issue Jul 28, 2015 · 2 comments

Comments

@riconnon
Copy link

When I create a file then add 2 ACLs to it using setfacl I get inconsistent updates of the ctime attribute.
I did the following:

zfs create tank/fs
zfs set xattr=sa tank
zfs set acltype=posixacl tank
touch /tank/fs/testfile
stat /tank/fs/testfile
setfacl -m u:user0:rwx /tank/fs/testfile
stat /tank/fs/testfile
setfacl -m u:user1:rwx /tank/fs/testfile
stat /tank/fs/testfile

I see the ctime changes between the first two stat outputs but not in the third.
@riconnon
Copy link
Author

The same behaviour happens without xattr=sa too.

@riconnon
Copy link
Author

Looking at this with relatively little prior knowledge it seems to me that zpl_xattr_set should probably always update ctime.

tonyhutter pushed a commit that referenced this issue Sep 13, 2017
@gaurkuma @tonyhutter
Modifying XATTRs doesnt change the ctime
d3e7d98 
Changing any metadata, should modify the ctime.

Reviewed-by: Chunwei Chen <tuxoko@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: gaurkuma <gauravk.18@gmail.com>
Closes #3644
Closes #6586
Fabian-Gruenbichler pushed a commit to Fabian-Gruenbichler/zfs that referenced this issue Sep 29, 2017
@gaurkuma @Fabian-Gruenbichler
Modifying XATTRs doesnt change the ctime
481d877 
Changing any metadata, should modify the ctime.

Reviewed-by: Chunwei Chen <tuxoko@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: gaurkuma <gauravk.18@gmail.com>
Closes openzfs#3644
Closes openzfs#6586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@behlendorf @riconnon