Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.5.6 release inclusion list [suggestions please] #4414

Closed
kernelOfTruth opened this issue Mar 14, 2016 · 8 comments
Closed

0.6.5.6 release inclusion list [suggestions please] #4414

kernelOfTruth opened this issue Mar 14, 2016 · 8 comments
Assignees

Comments

@kernelOfTruth
Copy link
Contributor

Well, that's at least what I'd include ;)


optional

a0bd735 Add support for asynchronous zvol minor operations


#4404 zfs hanged when multiple operations on dataset
#3681 lock order inversion between zvol_open() and dsl_pool_sync()...zvol_rename_minors()

??

1ee159f Fix lock order inversion with zvol_open()

5428dc5 Make zvol minor functionality more robust


c352ec2 Illumos 6370 - ZFS send fails to transmit some holes


513168a Make zvol update volsize operation synchronous.


zpool, command changes:

a77f29f Change full path subcommand flag from -p to -P

d2f3e29 Add -gLp to zpool subcommands for alt vdev names


eea9309 Prevent zpool_find_vdev() from truncating vdev path


0075955 Illumos 4448 - zfs diff misprints unicode characters


e989f19 Correctly parse -R flag arguments


9d36cdb Handling negative dentries in a CI file system.


8a09d5f Add l2arc_max_block_size tunable


and some more ...

to-be-added

@kernelOfTruth kernelOfTruth changed the title 0.6.5.6 release inclusion list 0.6.5.6 release inclusion list [suggestions please] Mar 14, 2016
@odoucet
Copy link

odoucet commented Mar 14, 2016

Even if I was really expecting "async zvol minor operations", I consider this a major change, so not to be included in a bugfix release. I would prefer releasing a 0.6.6 version with such patches (and not wait for 0.7, because if I see the issues tracker, this version is not close to be released ...).

@Sachiru
Copy link

Sachiru commented Mar 14, 2016

Perhaps this additional feature?

#4323

@behlendorf
Copy link
Contributor

Thanks for starting this list so we can track possible patches to apply to the next point release. I think some of these changes would be nice to have like async minors but are out of scope for a boring low risk point release.

Hopefully we can instead focus and getting an 0.7 release done. Some of the items flag for that release may just need to be bumped to the next tag so we can get it released.

@Fabian-Gruenbichler
Copy link
Contributor

Since #4404/#3681 seems to only be fixed with the "async zvol minor operations" cherry-picked as well, I would like to see it included in a release soon (if not 6.5.6, maybe 6.6 or 7 soon after?). This gets triggered pretty easily and has fatal consequences (all operations on the affected zpool hang, requiring a full reboot to fix).

@nedbass
Copy link
Contributor

nedbass commented Mar 23, 2016

We released 0.6.5.6 today.

Most of the above was included with the exception of these [reasons in bold]

8a09d5f Add l2arc_max_block_size tunable [new feature]
513168a Make zvol update volsize operation synchronous. [rare bug and not enough time on master]
0075955 Illumos 4448 - zfs diff misprints unicode characters [cosmetic change, ZoL already has a fix]

@nedbass nedbass closed this as completed Mar 23, 2016
@behlendorf behlendorf modified the milestone: 0.6.5.4 Mar 23, 2016
@kernelOfTruth
Copy link
Contributor Author

@nedbass thanks for the explanation !

@Sachiru
Copy link

Sachiru commented Mar 26, 2016

Thanks for the explanation. Please correct me if I'm wrong, but the
l2arc_max_block_size tunable should be okay, right? You're just waiting for
a feature release like 0.6.6 or 0.7, right?

Also, that code should be okay with the ABD work right?
On Mar 25, 2016 1:39 AM, "kernelOfTruth aka. kOT, Gentoo user" <
notifications@github.com> wrote:

@nedbass https://github.com/nedbass thanks for the explanation !


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#4414 (comment)

@behlendorf
Copy link
Contributor

@Sachiru right. There's nothing wrong with the patch if you want to cherry pick it. Just as a matter of policy new features aren't added to the stable release, this feature will appear in 0.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants