Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc_summary.py require review to proper reflect actual value for ZoL #5526

Closed
AndCycle opened this issue Dec 23, 2016 · 2 comments
Closed

arc_summary.py require review to proper reflect actual value for ZoL #5526

AndCycle opened this issue Dec 23, 2016 · 2 comments

Comments

@AndCycle
Copy link

this is just a note about this script,

as I am working with a munin plugin to proper present ZoL stats,
I found that arc_sumary.py is original written for FreeBSD,
and some of the arcstats it use to summarize the result is not actual value on ZoL.

for example,
p is stand for target size of MRU
so it use p as MRU size ,
size-p as MFU size,

on ZoL we do have independent mru_size and mfu_size value,
on my system MRU size is far off p which result in wrong conclusion for ARC Size Breakdown,

so I think this script require some review.

@AndCycle AndCycle changed the title arc_summary.py require review for proper reflect actual value for ZoL arc_summary.py require review to proper reflect actual value for ZoL Dec 23, 2016
@richardelling
Copy link
Contributor

p is the MRU target size, not the actual size

I suggest if you are writing an agent to go directly to the arc.c source for details and get the values directly from the /proc/spl/kstat/zfs/* rather than an intermediary script such as arc_summary

@AndCycle
Copy link
Author

that's what I am doing right now,

as arc_summary.py is included in current ZoL,
I just get some reference from it in order to find out what's matter,

Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Nov 4, 2017
Use mfu_size and mru_size pulled from the arcstats
kstat file to calculate the mfu and mru percentages
for arc size breakdown.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: AndCycle <andcycle@andcycle.idv.tw>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#5526
Closes openzfs#6770
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Nov 6, 2017
Use mfu_size and mru_size pulled from the arcstats
kstat file to calculate the mfu and mru percentages
for arc size breakdown.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: AndCycle <andcycle@andcycle.idv.tw>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#5526
Closes openzfs#6770
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Nov 21, 2017
Use mfu_size and mru_size pulled from the arcstats
kstat file to calculate the mfu and mru percentages
for arc size breakdown.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: AndCycle <andcycle@andcycle.idv.tw>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#5526 
Closes openzfs#6770
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Jan 29, 2018
Use mfu_size and mru_size pulled from the arcstats
kstat file to calculate the mfu and mru percentages
for arc size breakdown.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: AndCycle <andcycle@andcycle.idv.tw>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#5526
Closes openzfs#6770
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Feb 13, 2018
Use mfu_size and mru_size pulled from the arcstats
kstat file to calculate the mfu and mru percentages
for arc size breakdown.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: AndCycle <andcycle@andcycle.idv.tw>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#5526
Closes openzfs#6770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants