Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension to vdev_id script #6592

Closed
tesujimath opened this issue Sep 1, 2017 · 1 comment · Fixed by #6598
Closed

Extension to vdev_id script #6592

tesujimath opened this issue Sep 1, 2017 · 1 comment · Fixed by #6598

Comments

@tesujimath
Copy link
Contributor

I have a server which presents scsi disks rather than sas ones. It is therefore incompatible with the vdev_id script.

I have made some local modifications to this script to support what I am calling "scsi" topology. It works for me, but I am very aware that testing this sort of thing thoroughly requires access to a variety of hardware which I don't have.

Are you interested in a pull request with this extension?
@behlendorf
Copy link
Contributor

@tesujimath that sounds like a useful addition and something we'd consider including. If you open a PR with the proposed changes we'll be able to provide more concrete feedback.

tesujimath added a commit to tesujimath/zfs that referenced this issue Sep 3, 2017
@tesujimath
vdev_id: extension for new scsi topology.
ad25f86 
Resolves openzfs#6592.
tesujimath added a commit to tesujimath/zfs that referenced this issue Sep 3, 2017
@tesujimath
vdev_id: extension for new scsi topology.
4db59f8 
On systems with SCSI rather than SAS disk topology, this change enables
the vdev_id script to match against the block device path, and therefore
create a vdev alias in /dev/disk/by-vdev.

Resolves openzfs#6592.

Signed-off-by: Simon Guest <simon.guest@tesujimath.org>
tesujimath added a commit to tesujimath/zfs that referenced this issue Sep 3, 2017
@tesujimath
vdev_id: extension for new scsi topology.
7bbd894 
On systems with SCSI rather than SAS disk topology, this change enables
the vdev_id script to match against the block device path, and therefore
create a vdev alias in /dev/disk/by-vdev.

Resolves openzfs#6592.

Signed-off-by: Simon Guest <simon.guest@tesujimath.org>
@tesujimath tesujimath mentioned this issue Sep 4, 2017
Merged
13 tasks
behlendorf pushed a commit that referenced this issue Sep 27, 2017
@tesujimath @behlendorf
vdev_id: extension for new scsi topology
269db7a 
On systems with SCSI rather than SAS disk topology, this change enables
the vdev_id script to match against the block device path, and therefore
create a vdev alias in /dev/disk/by-vdev.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Simon Guest <simon.guest@tesujimath.org>
Closes #6592
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 30, 2019
@tesujimath @tonyhutter
vdev_id: extension for new scsi topology
0d58691 
On systems with SCSI rather than SAS disk topology, this change enables
the vdev_id script to match against the block device path, and therefore
create a vdev alias in /dev/disk/by-vdev.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Simon Guest <simon.guest@tesujimath.org>
Closes openzfs#6592
tonyhutter pushed a commit that referenced this issue Mar 4, 2019
@tesujimath @tonyhutter
vdev_id: extension for new scsi topology
2b8c3cb 
On systems with SCSI rather than SAS disk topology, this change enables
the vdev_id script to match against the block device path, and therefore
create a vdev alias in /dev/disk/by-vdev.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Simon Guest <simon.guest@tesujimath.org>
Closes #6592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vdev_id: extension for new scsi topology. tesujimath/zfs
2 participants
@behlendorf @tesujimath