Skip to content

zfs-0.7.2/cmd/zed/zed_conf.c: 2 * possible wrong operator ? #6684

@dcb314

Description

@dcb314

zfs-0.7.2/cmd/zed/zed_conf.c:397]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.
[zfs-0.7.2/cmd/zed/zed_conf.c:403]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is

    if ((st.st_mode & S_IWGRP) & !zcp->do_force) {

Maybe better code

    if ((st.st_mode & S_IWGRP) && !zcp->do_force) {

SImilar a few lines further down.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIndicates a good issue for first-time contributors

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions