Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libaio-devel requirement breaks built on Debian Sid #7829

Closed
spadegit opened this issue Aug 25, 2018 · 0 comments · Fixed by #7831
Closed

libaio-devel requirement breaks built on Debian Sid #7829

spadegit opened this issue Aug 25, 2018 · 0 comments · Fixed by #7831
Labels
Type: Building Indicates an issue related to building binaries

Comments

@spadegit
Copy link

Dear ZoL Developers,

since the last commit (55972a6) I can't build ZoL on my Debian Sid box anymore.

I don't really want to bother You, since this is just my local toy box, but wanted to bring this to your attention.

I installed the Debian package libaio-dev but no success:

dpkg -l | grep libaio

ii  libaio-dev:amd64                              0.3.111-1                               amd64        Linux kernel AIO access library - development files
ii  libaio1:amd64                                 0.3.111-1                               amd64        Linux kernel AIO access library - shared library

Since this might just be an isolated error resulting from some new/exotic constellation, please feel free to close this bug by your considerations.

In any way: thank You all for your great work, I am using ZoL for years now and enjoy using the fruits of your labor :).

System information

Type Version/Name
Distribution Name Siduction (Debian Sid Distro; siduction.org)
Distribution Version Rolling Release Model
Linux Kernel 4.18 (Linux spade-ng 4.18.5-towo.1-siduction-amd64 #1 SMP siduction 4.18-5 (2018-08-24) x86_64 GNU/Linux)
Architecture amd64
ZFS Version 0.7.10 - (git clone from master before build)
SPL Version -

Describe the problem you're observing

Since including libaio-devel into the requirements, building on my Debian system fails.

Describe how to reproduce the problem

  1. git clone https://github.com/zfsonlinux/zfs
  2. ./autogen.sh && ./configure
  3. LC_TIME=C make deb
    (setting env var to circumvent "make deb" fails due to "error: bad date in %changelog #7825 with my limited know how ;))

Include any warning/errors/backtraces from the system logs

make deb run exits at this:


make[2]: Verzeichnis „/home/sam/zfsonlinux/src/git/zfs“ wird verlassen
Installing zfs-0.7.0-1527_g55972a672.src.rpm
error: Failed build dependencies:
	libaio-devel is needed by zfs-0.7.0-1527_g55972a672.x86_64

I removed the requirement from rpm/generic/zfs.spec.in and make deb succeeded, maybe the Debian package does not provide files at the expected places or some other distribution specific characteristics?

Please ask for any possible helpful information, I will be happy to provide it ASAP.

Kind regards,

Martin

@loli10K loli10K added the Type: Building Indicates an issue related to building binaries label Aug 25, 2018
behlendorf pushed a commit that referenced this issue Aug 26, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not
work when building on Debian-based distributions.

Fix this issue by making this requirement conditional to RPM-based
distributions.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #7829 
Closes #7831
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 28, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not
work when building on Debian-based distributions.

Fix this issue by making this requirement conditional to RPM-based
distributions.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#7829 
Closes openzfs#7831
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 30, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not
work when building on Debian-based distributions.

Fix this issue by making this requirement conditional to RPM-based
distributions.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#7829
Closes openzfs#7831
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Sep 5, 2018
BuildRequires tags for "-devel" packages in the RPM spec file do not
work when building on Debian-based distributions.

Fix this issue by making this requirement conditional to RPM-based
distributions.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#7829
Closes openzfs#7831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants