Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need BuildRequires: gcc #8095

Closed
tonyhutter opened this issue Nov 5, 2018 · 0 comments · Fixed by #8102
Closed

Need BuildRequires: gcc #8095

tonyhutter opened this issue Nov 5, 2018 · 0 comments · Fixed by #8102
Labels
Type: Building Indicates an issue related to building binaries

Comments

@tonyhutter
Copy link
Contributor

System information

Type Version/Name
Distribution Name Fedora
Distribution Version 29
Linux Kernel -
Architecture -
ZFS Version master
SPL Version master

Describe the problem you're observing

The Fedora 29 mock environment no longer includes GCC by default:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/TDPFN4KWRZNGGLS4PGWDRFHRKFLVOHXA/

We should add a BuildRequires: gcc into our spec files. This has been a packaging requirement for awhile now:

If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Those packages will include everything that is required to build a standards conforming C or C++ application.

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

Describe how to reproduce the problem

Build zfs-0.7.12-hutter (#8078) in a F29 mock environment.

Include any warning/errors/backtraces from the system logs
@tonyhutter tonyhutter added the Type: Building Indicates an issue related to building binaries label Nov 5, 2018
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 6, 2018
@tonyhutter
Add BuildRequires: gcc, make, elfutils-libelf-devel
1e041da 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8095
@tonyhutter tonyhutter mentioned this issue Nov 6, 2018
Merged
12 tasks
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 7, 2018
@tonyhutter
Add BuildRequires: gcc, make, elfutils-libelf-devel
3ef21d7 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8095
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 7, 2018
@tonyhutter
Add BuildRequires gcc, make, elfutils-libelf-devel
c6c30d3 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8095
behlendorf pushed a commit that referenced this issue Nov 7, 2018
@tonyhutter @behlendorf
Add BuildRequires gcc, make, elfutils-libelf-devel
d7bda38 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes #8095
Closes #8102
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Nov 7, 2018
@tonyhutter
Add BuildRequires gcc, make, elfutils-libelf-devel
f900dc4 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8095
Closes openzfs#8102
tonyhutter added a commit that referenced this issue Nov 13, 2018
@tonyhutter
Add BuildRequires gcc, make, elfutils-libelf-devel
f42f870 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes #8095
Closes #8102
GregorKopka pushed a commit to GregorKopka/zfs that referenced this issue Jan 7, 2019
@tonyhutter
Add BuildRequires gcc, make, elfutils-libelf-devel
3307cd5 
This adds a BuildRequires for gcc, make, and elfutils-libelf-devel
into our spec files.  gcc has been a packaging requirement for
awhile now:

https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

These additional BuildRequires allow us to mock build in
Fedora 29.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:  Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8095
Closes openzfs#8102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BuildRequires: gcc, make, elfutils-libelf-devel tonyhutter/zfs
1 participant
@tonyhutter