Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 5.0: error: invalid operands to binary << #8263

Closed
tonyhutter opened this issue Jan 10, 2019 · 0 comments
Closed

Linux 5.0: error: invalid operands to binary << #8263

tonyhutter opened this issue Jan 10, 2019 · 0 comments
Assignees
@tonyhutter
Labels
Type: Building Indicates an issue related to building binaries
Projects
0.7.13

Comments

@tonyhutter
Copy link
Contributor

System information

Type Version/Name
Distribution Name Fedora
Distribution Version 30 (rawhide)
Linux Kernel 5.0.0-0.rc1.git0.1.fc30.x86_64
Architecture x86-64
ZFS Version master
SPL Version master

Describe the problem you're observing

totalram_pages was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper function.

Describe how to reproduce the problem

Build master in rawhide

Include any warning/errors/backtraces from the system logs

/home/hutter/current_kernel_time64/module/zfs/arc.c: In function ‘arc_all_memory’:
/home/hutter/current_kernel_time64/include/spl/sys/param.h:31:32: error: invalid operands to binary << (have ‘long unsigned int (*)(void)’ and ‘int’)
 #define ptob(pages)   ((pages) << PAGE_SHIFT)
                        ~       ^~
/home/hutter/current_kernel_time64/module/zfs/arc.c:4826:10: note: in expansion of macro ‘ptob’
  return (ptob(totalram_pages));
          ^~~~
/home/hutter/current_kernel_time64/module/zfs/arc.c:4831:1: error: control reaches end of non-void function [-Werror=return-type]
 }
 ^
@tonyhutter tonyhutter self-assigned this Jan 10, 2019
@tonyhutter tonyhutter added the Type: Building Indicates an issue related to building binaries label Jan 10, 2019
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
f7eaf68 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
c8c881f 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
246d6bd 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
c6bcfee 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Jan 16, 2019
@tonyhutter @behlendorf
Linux 5.0: Use totalram_pages()
b051839 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
32a5b2a 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
@tonyhutter tonyhutter mentioned this issue Jan 17, 2019
Closed
12 tasks
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
31dcbea 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
b5f9809 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
b9e1e25 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
871f6b2 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 23, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
bdd94a0 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 25, 2019
@tonyhutter
Linux 5.0: Use totalram_pages()
5cb7104 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes: openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 30, 2019
@tonyhutter
Linux 5.0 compat: Use totalram_pages()
3d9f637 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8263
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 12, 2019
@tonyhutter
Linux 5.0 compat: Use totalram_pages()
358812a 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8263
tonyhutter added a commit that referenced this issue Mar 4, 2019
@tonyhutter
Linux 5.0 compat: Use totalram_pages()
ba8024a 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #8263
@skeuchel skeuchel mentioned this issue Apr 27, 2019
Closed
allanjude pushed a commit to allanjude/zfs that referenced this issue Jun 29, 2019
@tonyhutter @allanjude
Linux 5.0 compat: Use totalram_pages()
67a5eca 
totalram_pages() was converted to an atomic variable in 5.0:

https://patchwork.kernel.org/patch/10652795/

Its value should now be read though the totalram_pages() helper
function.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyhutter tonyhutter

Labels
Type: Building Indicates an issue related to building binaries
Projects
No open projects
0.7.13
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonyhutter