Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux 5.0: MS_RDONLY undeclared #8264

Closed
tonyhutter opened this issue Jan 10, 2019 · 0 comments
Closed

Linux 5.0: MS_RDONLY undeclared #8264

tonyhutter opened this issue Jan 10, 2019 · 0 comments
Assignees
Labels
Type: Building Indicates an issue related to building binaries
Projects

Comments

@tonyhutter
Copy link
Contributor

System information

Type Version/Name
Distribution Name Fedora
Distribution Version 30 (rawhide)
Linux Kernel 5.0.0-0.rc1.git0.1.fc30.x86_64
Architecture c86-64
ZFS Version master
SPL Version master

Describe the problem you're observing

In the 5.0 kernel, only the mount namespace code should use the MS_* macos. Filesystems should use the SB_* ones: https://patchwork.kernel.org/patch/10552493/

Describe how to reproduce the problem

Build master in rawhide

Include any warning/errors/backtraces from the system logs

/home/hutter/current_kernel_time64/module/zfs/vdev_disk.c: In function ‘vdev_bdev_mode’:
/home/hutter/current_kernel_time64/module/zfs/vdev_disk.c:83:10: error: ‘MS_RDONLY’ undeclared (first use in this function); did you mean ‘IS_RDONLY’?
   mode = MS_RDONLY;
          ^~~~~~~~~
          IS_RDONLY
@tonyhutter tonyhutter self-assigned this Jan 10, 2019
@tonyhutter tonyhutter added the Type: Building Indicates an issue related to building binaries label Jan 10, 2019
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 15, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
behlendorf pushed a commit to behlendorf/zfs that referenced this issue Jan 16, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 23, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 25, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Jan 30, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit to tonyhutter/zfs that referenced this issue Feb 12, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes openzfs#8264
tonyhutter added a commit that referenced this issue Mar 4, 2019
In the 5.0 kernel, only the mount namespace code should use the MS_*
macos. Filesystems should use the SB_* ones.

https://patchwork.kernel.org/patch/10552493/

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #8264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Building Indicates an issue related to building binaries
Projects
No open projects
0.7.13
  
Awaiting triage
Development

No branches or pull requests

1 participant