Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 5.0: bio_associate_blkg() now GPL'd #8287

Closed
tonyhutter opened this issue Jan 15, 2019 · 2 comments
Closed

Linux 5.0: bio_associate_blkg() now GPL'd #8287

tonyhutter opened this issue Jan 15, 2019 · 2 comments
Labels
Status: Blocked Depends on another pending change

Comments

@tonyhutter
Copy link
Contributor

System information

Type Version/Name
Distribution Name Fedora
Distribution Version 30 (rawhide)
Linux Kernel 5.0.0-0.rc1.git0.1.fc30.x86_64
Architecture x86-64
ZFS Version master
SPL Version master

Describe the problem you're observing

bio_associate_blkg() is now GPL'd:

https://lore.kernel.org/lkml/20181205171039.73066-7-dennis@kernel.org/

Describe how to reproduce the problem

Build master in rawhide.

Include any warning/errors/backtraces from the system logs

FATAL: modpost: GPL-incompatible module zfs.ko uses GPL-only symbol 'bio_associate_blkg'
@tonyhutter
Copy link
Contributor Author

We call the function via bio_set_dev().

@tonyhutter tonyhutter added the Status: Blocked Depends on another pending change label Jan 15, 2019
@johnreitan
Copy link

We call the function via bio_set_dev().

bio_set_dev() is just a define for a do {} while 0; loop which included a call to bio_associate_blkg, so doesn't help.

tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
b94a2e4 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
74f844e 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287
@tonyhutter tonyhutter mentioned this issue Jan 17, 2019
Closed
12 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
1341a0b 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
36c1e0d 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287

Requires-builders: style|build|arch|distro|test|unstable
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 17, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
f197fb8 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287

Requires-builders: style,build,arch,distro,test,unstable
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
547a1d8 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287

Requires-builders: style,build,arch,distro,test,unstable
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
3672d22 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287

Requires-builders: style,build,arch,distro,test,unstable
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 22, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
157f917 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287

Requires-builders: style,build,arch,distro,test,unstable
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 23, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
916477f 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287

Requires-builders: style,build,arch,distro,test,unstable
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 23, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
267b11b 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 25, 2019
@behlendorf @tonyhutter
Linux 5.0: Fix bio_set_dev()
810c9db 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes: openzfs#8287
@netvl netvl mentioned this issue Jan 29, 2019
Closed
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Jan 30, 2019
@behlendorf @tonyhutter
Linux 5.0 compat: Fix bio_set_dev()
b36c679 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8287
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Feb 12, 2019
@behlendorf @tonyhutter
Linux 5.0 compat: Fix bio_set_dev()
a1f258f 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#8287
tonyhutter pushed a commit that referenced this issue Mar 4, 2019
@behlendorf @tonyhutter
Linux 5.0 compat: Fix bio_set_dev()
5c4ec38 
The Linux 5.0 kernel updated the bio_set_dev() macro so it calls the
GPL-only bio_associate_blkg() symbol thus inadvertently converting
the entire macro.  Provide a minimal version which always assigns the
request queue's root_blkg to the bio.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #8287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Blocked Depends on another pending change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonyhutter @johnreitan