Linux 5.6 compat #10064

behlendorf · 2020-02-26T21:59:54Z

Motivation and Context

Issue #10052. Compatibility changes to resolve the build failure with the
as yet unreleased Linux 5.6 kernel.

Description

Commit torvalds/linux@fb7fcc9 standardized several of the kernel time
interfaces in the 4.18 kernel. The legacy interfaces we were using have now been fully
retired. Update gethrtime() to use the replacement interface ktime_get_raw_ts64().
As part of the Linux kernel's y2038 changes the time_t type has been
fully retired. Callers are now required to use the time64_t type.

Rather than move to the new type, I've removed the few remaining
places where a time_t is used in the kernel code. They've been
replaced with a uint64_t which is already how ZFS internally
handled these values.

How Has This Been Tested?

Locally compiled against the v5.6-rc3-42-gc5f8689 kernel.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the ZFS on Linux code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes.
I have run the ZFS Test Suite with this change applied.
All commit messages are properly formatted and contain Signed-off-by.

The getrawmonotonic() and getrawmonotonic64() interfaces have been fully retired. Update gethrtime() to use the replacement interface ktime_get_raw_ts64() which was introduced in the 4.18 kernel. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>

As part of the Linux kernel's y2038 changes the time_t type has been fully retired. Callers are now required to use the time64_t type. Rather than move to the new type, I've removed the few remaining places where a time_t is used in the kernel code. They've been replaced with a uint64_t which is already how ZFS internally handled these values. Going forward we should work towards updating the remaining user space time_t consumers to the 64-bit interfaces. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>

tonyhutter

Looks good

codecov-io · 2020-02-27T05:52:52Z

Codecov Report

Merging #10064 into master will increase coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #10064    +/-   ##
========================================
+ Coverage      79%      79%   +<1%     
========================================
  Files         386      386            
  Lines      122303   122301     -2     
========================================
+ Hits        96985    97047    +62     
+ Misses      25318    25254    -64

Flag	Coverage Δ
#kernel	`80% <100%> (ø)`	⬇️
#user	`67% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abef699...67d0bb3. Read the comment docs.

As part of the Linux kernel's y2038 changes the time_t type has been fully retired. Callers are now required to use the time64_t type. Rather than move to the new type, I've removed the few remaining places where a time_t is used in the kernel code. They've been replaced with a uint64_t which is already how ZFS internally handled these values. Going forward we should work towards updating the remaining user space time_t consumers to the 64-bit interfaces. Reviewed-by: Matthew Macy <mmacy@freebsd.org> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #10052 Closes #10064

The getrawmonotonic() and getrawmonotonic64() interfaces have been fully retired. Update gethrtime() to use the replacement interface ktime_get_raw_ts64() which was introduced in the 4.18 kernel. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#10052 Closes openzfs#10064

As part of the Linux kernel's y2038 changes the time_t type has been fully retired. Callers are now required to use the time64_t type. Rather than move to the new type, I've removed the few remaining places where a time_t is used in the kernel code. They've been replaced with a uint64_t which is already how ZFS internally handled these values. Going forward we should work towards updating the remaining user space time_t consumers to the 64-bit interfaces. Reviewed-by: Matthew Macy <mmacy@freebsd.org> Reviewed-by: Tony Hutter <hutter2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#10052 Closes openzfs#10064