FreeBSD: Fix zfs jail and add a test
#10658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Status: Code Review Needed
The ioctl was not using zfs_ioctl. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
Codecov Report
@@ Coverage Diff @@
## master #10658 +/- ##
==========================================
+ Coverage 79.55% 79.70% +0.15%
==========================================
Files 394 394
Lines 124631 124631
==========================================
+ Hits 99146 99338 +192
+ Misses 25485 25293 -192
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
behlendorf
approved these changes
Aug 1, 2020
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
zfs_jail was not using zfs_ioctl so failed to map the IOC number correctly. Use zfs_ioctl to perform the jail ioctl and add a test case for FreeBSD. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10658
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
zfs_jail was not using zfs_ioctl so failed to map the IOC number correctly. Use zfs_ioctl to perform the jail ioctl and add a test case for FreeBSD. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
zfs_jailwas not usingzfs_ioctlso failed to map the IOC number correctly.Description
Use
zfs_ioctlto perform the jail ioctl.Add a test case for FreeBSD.
How Has This Been Tested?
./scripts/zfs-tests.sh -vxT zfs_jailon FreebsdTypes of changes
Checklist:
Signed-off-by.