Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnode_special_open() error: unchecked function return 'zrl_tryenter' #10876

Merged
merged 1 commit into from Sep 8, 2020
Merged

dnode_special_open() error: unchecked function return 'zrl_tryenter' #10876

merged 1 commit into from Sep 8, 2020

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Sep 3, 2020 •
edited

zrl_tryenter() can fail, so we should check it... or at least, so it seems...

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 3, 2020
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 4, 2020
@behlendorf behlendorf merged commit 189272f into openzfs:master Sep 8, 2020
@tsoome tsoome deleted the dnode_special_open branch September 8, 2020 19:36
@behlendorf behlendorf added this to Backport for OpenZFS 2.0 in OpenZFS 2.0 Sep 9, 2020
behlendorf pushed a commit that referenced this pull request Sep 9, 2020
@tsoome @behlendorf
dnode_special_open() error: unchecked function return 'zrl_tryenter'
b155a24 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Toomas Soome <tsoome@me.com>
Closes #10876
@behlendorf behlendorf moved this from Backport for OpenZFS 2.0 to Done in OpenZFS 2.0 Sep 9, 2020
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@tsoome @jsai20
dnode_special_open() error: unchecked function return 'zrl_tryenter'
ae43ce4 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Toomas Soome <tsoome@me.com>
Closes openzfs#10876
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@tsoome
dnode_special_open() error: unchecked function return 'zrl_tryenter'
d0ad75b 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Toomas Soome <tsoome@me.com>
Closes openzfs#10876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
No open projects
OpenZFS 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsoome @behlendorf