Return EFAULT at the end of zfs_write if set #11193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
zfs_write-efault
branch
from
1611e51
to
a582154
Compare
ghost
changed the title
|
Bah, I'll fix the style after I see the test results. |
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
force-pushed
the
zfs_write-efault
branch
from
a582154
to
e694b97
Compare
ghost
marked this pull request as ready for review
behlendorf
reviewed
Nov 12, 2020
ghost
force-pushed
the
zfs_write-efault
branch
from
e694b97
to
6478ba9
Compare
FreeBSD's VFS expects EFAULT from zfs_write if we didn't complete the full write so it can retry the operation. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
force-pushed
the
zfs_write-efault
branch
from
6478ba9
to
fd96841
Compare
|
behlendorf
approved these changes
Nov 12, 2020
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Dec 23, 2020
FreeBSD's VFS expects EFAULT from zfs_write() if we didn't complete the full write so it can retry the operation. Add some missing SET_ERRORs in zfs_write(). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #11193
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
FreeBSD's VFS expects EFAULT from zfs_write() if we didn't complete the full write so it can retry the operation. Add some missing SET_ERRORs in zfs_write(). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11193
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
FreeBSD's VFS expects EFAULT from zfs_write() if we didn't complete the full write so it can retry the operation. Add some missing SET_ERRORs in zfs_write(). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
FreeBSD expects some error from zfs_write if we didn't complete the full write.
This fixes the frequent failures in compression/compress_003_pos.
Description
Return
errorinstead of0at the end ofzfs_write.I noticed a few locations missing
SET_ERRORwhile here, so they have been added in a separate commit.How Has This Been Tested?
I ran the compression tests on FreeBSD to confirm compress_003_pos passed. More testing will be needed to see if the change negatively affects Linux.
Types of changes
Checklist:
Signed-off-by.