Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reporting of CKSUM errors in indirect vdevs #11277

Merged
merged 1 commit into from Dec 11, 2020
Merged

Fix reporting of CKSUM errors in indirect vdevs #11277

merged 1 commit into from Dec 11, 2020

Conversation

gamanakis
Copy link
Contributor

@gamanakis gamanakis commented Dec 3, 2020 •
edited

Motivation and Context

When removing and subsequently reattaching a vdev, CKSUM errors may occur
as vdev_indirect_read_all() reads from all children of a mirror in case
of a resilver.

Closes #11257

Description

Fix this by avoid reading from children which have the DTL_MISSING flag
set in case of a resilver.

How Has This Been Tested?

A test was added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gamanakis gamanakis marked this pull request as ready for review December 4, 2020 07:10
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Dec 4, 2020
@gamanakis
Copy link
Contributor Author

000bc38: Implemented strategy suggested by @behlendorf

@gamanakis
Copy link
Contributor Author

bc6fc9a: change return; to continue;

@gamanakis
Fix reporting of CKSUM errors in indirect vdevs
67c9b69 
When removing and subsequently reattaching a vdev, CKSUM errors may occur
as vdev_indirect_read_all() reads from all children of a mirror in case
of a resilver.

Fix this by checking whether a child is missing the data and setting a
flag (ic_error) which is then checked in vdev_indirect_repair() and
suppresses incrementing the checksum counter.

Signed-off-by: George Amanakis <gamanakis@gmail.com>
@gamanakis
Copy link
Contributor Author

67c9b69: use verify_pool in the test.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 10, 2020
@behlendorf behlendorf merged commit c76a40b into openzfs:master Dec 11, 2020
ghost pushed a commit to zfsonfreebsd/ZoF that referenced this pull request Dec 23, 2020
@gamanakis
Fix reporting of CKSUM errors in indirect vdevs
d833ffb 
When removing and subsequently reattaching a vdev, CKSUM errors may
occur as vdev_indirect_read_all() reads from all children of a mirror
in case of a resilver.

Fix this by checking whether a child is missing the data and setting a
flag (ic_error) which is then checked in vdev_indirect_repair() and
suppresses incrementing the checksum counter.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#11277
behlendorf pushed a commit that referenced this pull request Dec 23, 2020
@gamanakis @behlendorf
Fix reporting of CKSUM errors in indirect vdevs
900480b 
When removing and subsequently reattaching a vdev, CKSUM errors may
occur as vdev_indirect_read_all() reads from all children of a mirror
in case of a resilver.

Fix this by checking whether a child is missing the data and setting a
flag (ic_error) which is then checked in vdev_indirect_repair() and
suppresses incrementing the checksum counter.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes #11277
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@gamanakis @jsai20
Fix reporting of CKSUM errors in indirect vdevs
f35cfee 
When removing and subsequently reattaching a vdev, CKSUM errors may
occur as vdev_indirect_read_all() reads from all children of a mirror
in case of a resilver.

Fix this by checking whether a child is missing the data and setting a
flag (ic_error) which is then checked in vdev_indirect_repair() and
suppresses incrementing the checksum counter.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#11277
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@gamanakis
Fix reporting of CKSUM errors in indirect vdevs
266903d 
When removing and subsequently reattaching a vdev, CKSUM errors may
occur as vdev_indirect_read_all() reads from all children of a mirror
in case of a resilver.

Fix this by checking whether a child is missing the data and setting a
flag (ic_error) which is then checked in vdev_indirect_repair() and
suppresses incrementing the checksum counter.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#11277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@ahrens ahrens Awaiting requested review from ahrens

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing a vdev and attaching it to another vdev results in CKSUM errors during resilver
2 participants
@gamanakis @behlendorf