Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdev_id: Return an error if stdout contains output not suitable for udev rule consumption #12508

Merged
merged 1 commit into from Aug 25, 2021
Merged

vdev_id: Return an error if stdout contains output not suitable for udev rule consumption #12508

merged 1 commit into from Aug 25, 2021

Conversation

rugubara
Copy link
Contributor

Motivation and Context

The udev helper is supposed to return 0 exit code only when it produced the stdout suitable for consumption by the udev rule. error messages and usage messages should produce non-zero exit code that guarantees udev rule ignores the stdout.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@rugubara
vdev_id: Return an error if config file is not found
3c11ef1 
Signed-off-by: Anton Gubarkov <anton.gubarkov@gmail.com>
@rugubara rugubara mentioned this pull request Aug 24, 2021
Closed
13 tasks
tonyhutter
tonyhutter approved these changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@tonyhutter tonyhutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rugubara

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Aug 24, 2021
@tonyhutter tonyhutter merged commit b0f3f39 into openzfs:master Aug 25, 2021
rincebrain pushed a commit to rincebrain/zfs that referenced this pull request Sep 22, 2021
@rugubara @rincebrain
vdev_id: Return an error if config file is not found (openzfs#12508)
fd8a373 
Signed-off-by: Anton Gubarkov <anton.gubarkov@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 2, 2021
@rugubara @tonyhutter
vdev_id: Return an error if config file is not found (openzfs#12508)
3e784cc 
Signed-off-by: Anton Gubarkov <anton.gubarkov@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@rugubara @tonyhutter
vdev_id: Return an error if config file is not found (openzfs#12508)
304d1b9 
Signed-off-by: Anton Gubarkov <anton.gubarkov@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@rugubara @tonyhutter
vdev_id: Return an error if config file is not found (openzfs#12508)
728cf93 
Signed-off-by: Anton Gubarkov <anton.gubarkov@gmail.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@tonyhutter tonyhutter tonyhutter approved these changes

Assignees

@tonyhutter tonyhutter

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rugubara @behlendorf @tonyhutter