Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated REMAKE_INITRD dkms option #12781

Merged
merged 1 commit into from Nov 30, 2021
Merged

Remove deprecated REMAKE_INITRD dkms option #12781

merged 1 commit into from Nov 30, 2021

Conversation

kylosus
Copy link
Contributor

@kylosus kylosus commented Nov 21, 2021

Motivation and Context

Noticed a deprecation warning while building.

Description

The option at the moment seens to be doing nothing as it has been deprecated, and will break packaging in future versions. See dell/dkms@7114c62

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gamanakis
Copy link
Contributor

Looks good to me. REMAKE_INITRD defaulted to no either way, I think there is no harm in removing it to silence the deprecation warning.
Nit: The commit message contains a line with more than 72 characters. Could you fix that, ie break to a new line?

@kylosus
Remove REMAKE_INITRD
070aec5 
The option has been deprecated in dkms and will break packaging in
future versions. See dell/dkms@7114c62

Signed-off-by: jokersus <jokersus.cava@gmail.com>
@kylosus
Copy link
Contributor Author

kylosus commented Nov 25, 2021

Looks good to me. REMAKE_INITRD defaulted to no either way, I think there is no harm in removing it to silence the deprecation warning. Nit: The commit message contains a line with more than 72 characters. Could you fix that, ie break to a new line?

My bad, I fixed to commit now.

@behlendorf behlendorf merged commit b5c1686 into openzfs:master Nov 30, 2021
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Nov 30, 2021
@behlendorf behlendorf mentioned this pull request Dec 16, 2021
Closed
nabijaczleweli pushed a commit to nabijaczleweli/zfs that referenced this pull request May 6, 2022
@kylosus @nabijaczleweli
Remove REMAKE_INITRD
41a1654 
The option has been deprecated in dkms and will break packaging in
future versions. See dell/dkms@7114c62

Upstream-commit: b5c1686
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: jokersus <jokersus.cava@gmail.com>
Closes openzfs#12781
behlendorf pushed a commit that referenced this pull request May 6, 2022
@kylosus @behlendorf
Remove REMAKE_INITRD
bc03fee 
The option has been deprecated in dkms and will break packaging in
future versions. See dell/dkms@7114c62

Upstream-commit: b5c1686
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: jokersus <jokersus.cava@gmail.com>
Closes #12781
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@kylosus @nicman23
Remove REMAKE_INITRD
3e98e43 
The option has been deprecated in dkms and will break packaging in
future versions. See dell/dkms@7114c62

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: jokersus <jokersus.cava@gmail.com>
Closes openzfs#12781
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@kylosus @nicman23
Remove REMAKE_INITRD
ee28568 
The option has been deprecated in dkms and will break packaging in
future versions. See dell/dkms@7114c62

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Amanakis <gamanakis@gmail.com>
Signed-off-by: jokersus <jokersus.cava@gmail.com>
Closes openzfs#12781
@Zocker1999NET Zocker1999NET mentioned this pull request Dec 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gamanakis gamanakis gamanakis approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylosus @gamanakis @behlendorf