Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs-dkms rpm: Fix scriptlets dependencies #12832

Merged
merged 1 commit into from Dec 12, 2021

Conversation

tyll
Copy link
Contributor

@tyll tyll commented Dec 10, 2021

To ensure that the necessary packages are available during the %post and
%preun scriptlets, require them properly.

Fixes #12822

Motivation and Context

Fixes #12822

Description

Dependencies for scriptlets need to be specified specifically, see examples at:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/

How Has This Been Tested?

I did not test this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

To ensure that the necessary packages are available during the %post and
%preun scriptlets, require them properly.

Fixes openzfs#12822

Signed-off-by: Till Maas <opensource@till.name>
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I verified this works as intended on Fedora 35.

Running dnf install zfs was sufficient to pull in both the dkms and kernel-devel packages in the right order.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 10, 2021
@behlendorf behlendorf merged commit 4a5b6ce into openzfs:master Dec 12, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 13, 2021
To ensure that the necessary packages are available during the %post and
%preun scriptlets, require them properly.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Till Maas <opensource@till.name>
Closes openzfs#12822
Closes openzfs#12832
@tyll tyll deleted the rpm-dependencies branch December 14, 2021 16:55
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
To ensure that the necessary packages are available during the %post and
%preun scriptlets, require them properly.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Till Maas <opensource@till.name>
Closes openzfs#12822
Closes openzfs#12832
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
To ensure that the necessary packages are available during the %post and
%preun scriptlets, require them properly.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Till Maas <opensource@till.name>
Closes openzfs#12822
Closes openzfs#12832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation order issue
3 participants