Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ZERO_PAGE detection #13199

Merged
merged 1 commit into from Mar 14, 2022
Merged

Adding ZERO_PAGE detection #13199

merged 1 commit into from Mar 14, 2022

Conversation

bwatkinson
Copy link
Contributor

@bwatkinson bwatkinson commented Mar 12, 2022 •
edited

On some architectures ZERO_PAGE is unavailable because it referecnes
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Signed-off-by: Brian Atkinson batkinson@lanl.gov

Just added a m4 check to see if using ZERO_PAGE(0) results in a conflict in
case empty_zero_page is a GPL exported symbol.

Motivation and Context

Just some code cleanup. Also the check for ZERO_PAGE's availability will be needed by #10018.

Description

Added a m4 check to see if ZERO_PAGE(0) can be used. If it is available, then it can simply
be assigned to abd_zero_page in the _KERNEL portion of the code avoiding both an
necessary allocation and free for the abd_zero_scatter ABD.

How Has This Been Tested?

Tested with zloop.sh and also made sure compilation would work in the event
HAVE_ZERO_PAGE_GPL_ONLY is either defined or undefined in zfs_config.h.

Distro: CentOS 8.2.2004
Kernel: 5.15.13-1.el8.elrepo.x86_64

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@bwatkinson
Adding ZERO_PAGE detection
3725aa5 
On some architectures ZERO_PAGE is unavailable because it referecnes
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
@behlendorf behlendorf self-requested a review March 12, 2022 01:06
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Mar 12, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Mar 14, 2022
@behlendorf behlendorf merged commit becc717 into openzfs:master Mar 14, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 17, 2022
@bwatkinson @behlendorf
Adding ZERO_PAGE detection
904454d 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
behlendorf pushed a commit that referenced this pull request May 20, 2022
@bwatkinson @behlendorf
Adding ZERO_PAGE detection
60fc173 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes #13199
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@bwatkinson @nicman23
Adding ZERO_PAGE detection
d572c18 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@bwatkinson @nicman23
Adding ZERO_PAGE detection
ab1b693 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Aug 30, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
49f37fb 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@bwatkinson @lundman
Adding ZERO_PAGE detection
1d1b598 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@bwatkinson @beren12
Adding ZERO_PAGE detection
bb5d9a5 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
fa28bf5 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
2b3543c 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
8c918cc 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
28618a4 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
807afc5 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
94c56f5 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
fa48f6e 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
922086d 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
8ca7755 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
9700e75 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
c7593f4 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@bwatkinson @andrewc12
Adding ZERO_PAGE detection
379ef2c 
On some architectures ZERO_PAGE is unavailable because it references
a GPL exported symbol of empty_zero_page. Originally e08b993 removed
the call to PAGE_ZERO(0) for assignment to the abd_zero_page. However,
a simple check can be done to avoid a kernel allocation and free for
the abd_zero_page if ZERO_PAGE is available.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Brian Atkinson <batkinson@lanl.gov>
Closes openzfs#13199
@fantix fantix mentioned this pull request Oct 13, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bwatkinson @behlendorf