Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize RHEL version check in packages #13501

Merged
merged 1 commit into from May 25, 2022
Merged

Standardize RHEL version check in packages #13501

merged 1 commit into from May 25, 2022

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

https://github.com/openzfs/zfs/pull/13490/files#r880738282

Description

This is a follow up to 3c35662 which standardizes how the RHEL
version check is done. This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

cc: @Conan-Kudo

How Has This Been Tested?

Locally built packages.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Standardize RHEL version check in packages
71d315b 
This is a follow up to 3c35662 which standarizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Component: Packaging custom packages label May 24, 2022
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 24, 2022
@behlendorf behlendorf merged commit 61ef687 into openzfs:master May 25, 2022
behlendorf added a commit to behlendorf/zfs that referenced this pull request May 25, 2022
@behlendorf
Standardize RHEL version check in packages
14adcb1 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
behlendorf added a commit that referenced this pull request May 27, 2022
@behlendorf
Standardize RHEL version check in packages
ed16dd7 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #13501
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
Standardize RHEL version check in packages
5bd817b 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@behlendorf @nicman23
Standardize RHEL version check in packages
a7e40d5 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 12, 2022
@behlendorf @lundman
Standardize RHEL version check in packages
08a0fff 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@behlendorf @beren12
Standardize RHEL version check in packages
8ae3676 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
aa3d5f6 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
0a6a1cf 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
4731f18 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
3a1e953 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
23365a5 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
f104bba 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
a197ab8 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
353ac46 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
35ee77c 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
0c19083 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
21db326 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
27ace05 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
920e19d 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
ec84968 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
22ec059 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
ee5f343 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
99f61ea 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
578480f 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
426e516 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
9dedd4a 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
8bbbc95 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
f3d47ea 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
8a362a7 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
dd13485 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
e95ba38 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@behlendorf @andrewc12
Standardize RHEL version check in packages
f37cd41 
This is a follow up to 3c35662 which standardizes how the RHEL
version check is done.  This simpler "0%{?rhel}" check is used
elsewhere in the packages so we do the same here.

Reviewed-by: Neal Gompa <ngompa@datto.com>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#13501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rincebrain rincebrain rincebrain approved these changes

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

Assignees
No one assigned
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@behlendorf @rincebrain @Conan-Kudo