Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict visibility of per-dataset kstats inside FreeBSD jails #14254

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Restrict visibility of per-dataset kstats inside FreeBSD jails #14254

merged 1 commit into from
Dec 9, 2022

Conversation

allanjude
Copy link
Contributor

@allanjude allanjude commented Dec 3, 2022 •
edited
Loading

Motivation and Context

When inside a jail, visibility on datasets not "jailed" to the jail is restricted. However, it was possible to enumerate all datasets in the pool by looking at the kstats sysctl MIB.

Only the kstats corresponding to datasets that the user has visibility on are accessible now.

Sponsored-by: Klara Inc.
Signed-off-by: Allan Jude allan@klarasystems.com

Description

Restrict visibility on kstat system MIBs for per-dataset kstats

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 3, 2022
ryao
ryao approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@ryao ryao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me in that it is consistent with all of the other FreeBSD sysctl code that I have seen.

@allanjude
Restrict visibility of per-dataset kstats inside FreeBSD jails
59fa9c7 
When inside a jail, visibility on datasets not "jailed" to the
jail is restricted. However, it was possible to enumerate all
datasets in the pool by looking at the kstats sysctl MIB.

Only the kstats corresponding to datasets that the user has
visibility on are accessible now.

Sponsored-by: Klara Inc.
Signed-off-by: Allan Jude <allan@klarasystems.com>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 9, 2022
@behlendorf behlendorf merged commit f900279 into openzfs:master Dec 9, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 17, 2022
@allanjude @andrewc12
Restrict visibility of per-dataset kstats inside FreeBSD jails
3c0fddf 
When inside a jail, visibility on datasets not "jailed" to the
jail is restricted. However, it was possible to enumerate all
datasets in the pool by looking at the kstats sysctl MIB.

Only the kstats corresponding to datasets that the user has
visibility on are accessible now.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14254
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 13, 2023
@allanjude @tonyhutter
Restrict visibility of per-dataset kstats inside FreeBSD jails
6332edd 
When inside a jail, visibility on datasets not "jailed" to the
jail is restricted. However, it was possible to enumerate all
datasets in the pool by looking at the kstats sysctl MIB.

Only the kstats corresponding to datasets that the user has
visibility on are accessible now.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14254
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 18, 2023
@allanjude @tonyhutter
Restrict visibility of per-dataset kstats inside FreeBSD jails
e7ec569 
When inside a jail, visibility on datasets not "jailed" to the
jail is restricted. However, it was possible to enumerate all
datasets in the pool by looking at the kstats sysctl MIB.

Only the kstats corresponding to datasets that the user has
visibility on are accessible now.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14254
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jan 19, 2023
@allanjude @tonyhutter
Restrict visibility of per-dataset kstats inside FreeBSD jails
6219190 
When inside a jail, visibility on datasets not "jailed" to the
jail is restricted. However, it was possible to enumerate all
datasets in the pool by looking at the kstats sysctl MIB.

Only the kstats corresponding to datasets that the user has
visibility on are accessible now.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Allan Jude <allan@klarasystems.com>
Closes openzfs#14254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@ryao ryao ryao approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allanjude @behlendorf @ryao