Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark TX_COMMIT transaction with TXG_NOTHROTTLE #14798

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Mark TX_COMMIT transaction with TXG_NOTHROTTLE #14798

merged 1 commit into from
Apr 27, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Apr 26, 2023

TX_COMMIT has no on-disk representation and does not produce any more dirty data. It should not wait for anything, and even just skipping the checks if not waiting gives improvement noticeable in profiler.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Apr 26, 2023
@amotin amotin requested a review from behlendorf April 26, 2023 16:40
prakashsurya
prakashsurya approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable at first glance.. I don't think I thought much about the TXG flags, so not surprised I missed an optimization like this in the original change.. if it passes testing, looks good to me.

@amotin
Mark TX_COMMIT transaction with TXG_NOTHROTTLE.
9d37b32 
TX_COMMIT has no on-disk representation and does not produce any more
dirty data.  It should not wait for anything, and even just skipping
the checks if not waiting gives improvement noticeable in profiler.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@behlendorf behlendorf merged commit 2fd1c30 into openzfs:master Apr 27, 2023
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request May 1, 2023
@amotin @andrewc12
Mark TX_COMMIT transaction with TXG_NOTHROTTLE.
7d15ebc 
TX_COMMIT has no on-disk representation and does not produce any more
dirty data.  It should not wait for anything, and even just skipping
the checks if not waiting gives improvement noticeable in profiler.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#14798
amotin added a commit to amotin/zfs that referenced this pull request Jun 2, 2023
@amotin
Mark TX_COMMIT transaction with TXG_NOTHROTTLE.
7ef55c4 
TX_COMMIT has no on-disk representation and does not produce any more
dirty data.  It should not wait for anything, and even just skipping
the checks if not waiting gives improvement noticeable in profiler.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#14798
behlendorf pushed a commit that referenced this pull request Jun 2, 2023
@amotin @behlendorf
Mark TX_COMMIT transaction with TXG_NOTHROTTLE.
c1b9dc7 
TX_COMMIT has no on-disk representation and does not produce any more
dirty data.  It should not wait for anything, and even just skipping
the checks if not waiting gives improvement noticeable in profiler.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Prakash Surya <prakash.surya@delphix.com>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #14798
@amotin amotin deleted the tx_commit branch October 9, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@prakashsurya prakashsurya prakashsurya approved these changes

Assignees
No one assigned
Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @behlendorf @prakashsurya