Improve error message consistency #656
Conversation
Signed-off-by: Richard Laager <rlaager@wiktel.com>
|
Brian Behlendorf wrote:
I've updated the pull request to take that approach. I also improved a couple of other error messages so this set is consistent. By the way, do you have any idea why they're using ("%d", errno) rather than ("%s", strerror(errno))? |
|
I'm just guessing, but I suspect the ("%d", errno) syntax was use because it was the personal preference of whomever wrote this code originally. As a developer I personally find it clearer, however as an end user I suspect the ("%s", strerror(errno)) is a little nicer. Anyway, I've merged this change as commit 109491a |
The kernel_read & kernel_write functions have always wrapped the vfs_read & vfs_write functions respectively. However, they could not be used by vn_rdwr() since the offset wasn't passed as a pointer. This prevented us from being able to properly update the file offset. Linux 4.14 unexported vfs_read & vfs_write but also changed the signature of kernel_read & kernel_write to provide the needed functionality. Use these updated functions when available. Reviewed-by: Pritam Baral <pritam@pritambaral.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#656 Closes openzfs#667
No description provided.