Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim new line from zfs_vdev_scheduler #6573

Merged
merged 1 commit into from Sep 5, 2017
Merged

Trim new line from zfs_vdev_scheduler #6573

merged 1 commit into from Sep 5, 2017

Conversation

behlendorf
Copy link
Contributor

Description

Add a helper function to trim the tailing new line. While we're
here use this new hook to immediately apply the new scheduler.

Motivation and Context

#3356

How Has This Been Tested?

Locally in a VM by explicitly changing the scheduler.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@behlendorf
Trim new line from zfs_vdev_scheduler
3aac98f 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#3356
@behlendorf behlendorf merged commit e771de5 into openzfs:master Sep 5, 2017
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 15, 2018
@behlendorf @tonyhutter
Trim new line from zfs_vdev_scheduler
0d7396c 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3356 
Closes openzfs#6573
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2018
@behlendorf @tonyhutter
Trim new line from zfs_vdev_scheduler
c6be89f 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3356 
Closes openzfs#6573
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 5, 2018
@behlendorf @tonyhutter
Trim new line from zfs_vdev_scheduler
4805781 
Add a helper function to trim the tailing new line.  While we're
here use this new hook to immediately apply the new scheduler.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3356 
Closes openzfs#6573
@behlendorf behlendorf deleted the issue-3356 branch April 19, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinatale2 dinatale2 dinatale2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@behlendorf @dinatale2