Fixes for SPARC support #6750
Merged
Fixes for SPARC support #6750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
requested changes
Oct 11, 2017
module/icp/algs/sha1/sha1.c
Outdated
| SHA1Transform((ctx)->state[0], (ctx)->state[1], (ctx)->state[2], \ | ||
| (ctx)->state[3], (ctx)->state[4], (ctx), (in)) | ||
| SHA1Transform((ctx)->state[0], (ctx)->state[1], (ctx)->state[2], \ | ||
| (ctx)->state[3], (ctx)->state[4], (ctx), (in)) |
There was a problem hiding this comment.
nit: It looks like this style fix should be in 3b05b50
There was a problem hiding this comment.
I've rebased the branch and that styling issue fix is now in its correct place.
lib/libspl/Makefile.am
Outdated
| @@ -13,7 +13,8 @@ DEFAULT_INCLUDES += \ | |||
| -I$(top_srcdir)/lib/libspl/include | |||
|
|
|||
| AM_CCASFLAGS = \ | |||
| -I$(top_srcdir)/lib/libspl/include | |||
| -I$(top_srcdir)/lib/libspl/include \ | |||
| $(CFLAGS) | |||
There was a problem hiding this comment.
It looks like you can remove -I$(top_srcdir)/lib/libspl/include from AM_CCASFLAGS while you're here to simplify things. CPPASCOMPILE and LTCPPASCOMPILE both already include DEFAULT_INCLUDES.
There was a problem hiding this comment.
Added a new commit to remove that line.
Codecov Report
@@ Coverage Diff @@
## master #6750 +/- ##
=========================================
+ Coverage 74.1% 74.21% +0.1%
=========================================
Files 295 295
Lines 93905 93905
=========================================
+ Hits 69591 69687 +96
+ Misses 24314 24218 -96
Continue to review full report at Codecov.
|
Passing arguments explicitly into SHA1Transform() increases the number of registers abailable to the compiler, hence leaving more local and out registers available. The missing symbol of sha1_consts[], which prevents compiling on SPARC, is added back, which speeds up the process of utilizing the relative constants. This should fix #6738. Signed-off-by: Pengcheng Xu <i@jsteward.moe>
Normally a SPARC processor runs in big endian mode. Save the extra labor needed for little endian machines when the target is a big endian one (sparc). Signed-off-by: Pengcheng Xu <i@jsteward.moe>
It's important to respect the user's CFLAGS as mismatched -mcpu will directly result in the assembler not able to produce correct code. Fixes #6733. Signed-off-by: Pengcheng Xu <i@jsteward.moe>
CPPASCOMPILE and LTCPPASCOMPILE all include DEFAULT_INCLUDES, hence it's unnecessary to add the includes again. Signed-off-by: Pengcheng Xu <i@jsteward.moe>
aerusso
pushed a commit
to aerusso/zfs
that referenced
this pull request
Oct 12, 2017
The current code base almost compiles on SPARC, but a few fixes are required for the code to compile (and work efficiently). Code in this PR comes from OpenZFS project which was initially dropped when porting the crypto framework. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pengcheng Xu <i@jsteward.moe> Closes openzfs#6733 Closes openzfs#6738 Closes openzfs#6750
tonyhutter
pushed a commit
that referenced
this pull request
Oct 16, 2017
The current code base almost compiles on SPARC, but a few fixes are required for the code to compile (and work efficiently). Code in this PR comes from OpenZFS project which was initially dropped when porting the crypto framework. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pengcheng Xu <i@jsteward.moe> Closes #6733 Closes #6738 Closes #6750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current code base almost compiles on SPARC, yet a few fixes are required for the code to compile
(and work efficiently). Code in this PR comes from OpenZFS project, nearly all of them dates back
to OpenZFS launch (~12 yrs ago).
Motivation and Context
Fixes #6738.
Fixes #6733.
How Has This Been Tested?
Compile passed (including all compile-time unit tests) on an UltraSPARC T2 machine (namely a Sun Enterprise T5120).
ztestfinished successfully with return value 0.Types of changes
Checklist:
Signed-off-by.