Explicitly depend on icp module in initramfs hook #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic dependency resolution is unreliable on many systems. Follow suit with existing code, and explicitly include icp in module dependencies. Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
behlendorf
approved these changes
Oct 11, 2017
gmelikov
approved these changes
Oct 12, 2017
aerusso
added a commit
to aerusso/zfs
that referenced
this pull request
Oct 12, 2017
Automatic dependency resolution is unreliable on many systems. Follow suit with existing code, and explicitly include icp in module dependencies. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com> Closes openzfs#6751
tonyhutter
pushed a commit
that referenced
this pull request
Oct 16, 2017
Automatic dependency resolution is unreliable on many systems. Follow suit with existing code, and explicitly include icp in module dependencies. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com> Closes #6751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic dependency resolution is unreliable on many systems.
Follow suit with existing code, and explicitly include icp
in module dependencies.
Signed-off-by: Antonio Russo antonio.e.russo@gmail.com
Motivation and Context
BASE_MODULES in the initramfs hooks file claims that dependency
resolution is fragile. If this is true, we should include the required icp
module in this list.
How Has This Been Tested?
I've built a package containing this, and installed it. I don't (yet) have a system close to being zfs on root, so I cannot honestly test this easily.
Types of changes
Checklist:
Signed-off-by.