arcstat: flush stdout / outfile after each line #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinatale2
approved these changes
Oct 23, 2017
|
@Fabian-Gruenbichler can you run this thru full testing? |
behlendorf
approved these changes
Oct 23, 2017
otherwise, if arcstat gets interrupted before the desired number of iterations is reached, the output file will be empty (both if set via '-o' or via shell redirection). Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Requires-builders: test
Fabian-Gruenbichler
force-pushed
the
pull/flush_arcstat_stdout
branch
from
5701bad
to
8d69cd3
Compare
|
On Mon, Oct 23, 2017 at 08:34:57PM +0000, Giuseppe Di Natale wrote:
@Fabian-Gruenbichler can you run this thru full testing?
sure thing. figured I'd save some build bot time since there is only one
test case concering arcstat currently, which does not check output
anyway :P
so - here it goes ;)
|
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Nov 4, 2017
Otherwise, if arcstat gets interrupted before the desired number of iterations is reached, the output file will be empty (both if set via '-o' or via shell redirection). Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes openzfs#6775
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Nov 6, 2017
Otherwise, if arcstat gets interrupted before the desired number of iterations is reached, the output file will be empty (both if set via '-o' or via shell redirection). Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes openzfs#6775
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Nov 21, 2017
Otherwise, if arcstat gets interrupted before the desired number of iterations is reached, the output file will be empty (both if set via '-o' or via shell redirection). Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes openzfs#6775
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Jan 29, 2018
Otherwise, if arcstat gets interrupted before the desired number of iterations is reached, the output file will be empty (both if set via '-o' or via shell redirection). Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes openzfs#6775
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Feb 13, 2018
Otherwise, if arcstat gets interrupted before the desired number of iterations is reached, the output file will be empty (both if set via '-o' or via shell redirection). Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> Closes openzfs#6775
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flush after every output line
Motivation and Context
currently, the following produce empty output files if interrupted/killed (e.g., with C-c / SIGINT) before Y iterations have been done:
arcstat -o logfile X Yarcstat X Y > logfilethe same is true for the following, which MUST be interrupted/killed to exit:
arcstat -o logfile Xarcstat X > logfileHow Has This Been Tested?
tested the above commands without and with flushing, compare resulting log files (empty vs. correct content). the one existing arcstat test case does not catch this as it redirects output to /dev/null and only checks the exit code (it also does not check any invocation with iterations anyway).
Types of changes
Checklist:
Signed-off-by.