Add Coverity defect fix commit checker support #6777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinatale2
force-pushed
the
coverity-commit-checker
branch
4 times, most recently
from
29a9338 to
d11cddd
Compare
behlendorf
requested changes
Oct 23, 2017
scripts/commitcheck.sh
Outdated
|
|
||
| function is_coverity_fix() | ||
| { | ||
| # subject starts with OpenZFS means it's an openzfs port |
There was a problem hiding this comment.
Update the comment here to reflect this is a coverify not openzfs commit.
There was a problem hiding this comment.
Good catch, fixed.
dinatale2
force-pushed
the
coverity-commit-checker
branch
from
d11cddd to
4528e4e
Compare
dinatale2
commented
Oct 24, 2017
| git log -n 1 --pretty=%b "$REF" | egrep '^CID' | while read -r line; do | ||
| echo "$line" | egrep '^CID [[:digit:]]+: ([[:graph:]]+|[[:space:]])+ \(([[:upper:]]|\_)+\)' > /dev/null | ||
| if [[ $? -ne 0 ]]; then | ||
| echo "error: commit message has an improperly formatted CID defect line" |
There was a problem hiding this comment.
I think there's going to be a subshell problem here... going to need to fix that.
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
dinatale2
force-pushed
the
coverity-commit-checker
branch
from
4528e4e to
8c54df9
Compare
Codecov Report
@@ Coverage Diff @@
## master #6777 +/- ##
==========================================
- Coverage 75.17% 74.49% -0.69%
==========================================
Files 297 297
Lines 94374 94371 -3
==========================================
- Hits 70947 70298 -649
- Misses 23427 24073 +646
Continue to review full report at Codecov.
|
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Nov 4, 2017
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#6777
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Nov 6, 2017
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#6777
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Jan 18, 2018
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#6777
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Jan 29, 2018
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#6777
Nasf-Fan
pushed a commit
to Nasf-Fan/zfs
that referenced
this pull request
Feb 13, 2018
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#6777
FransUrbo
pushed a commit
to FransUrbo/zfs
that referenced
this pull request
Apr 28, 2019
Enable commitcheck.sh to test if a commit message is in the expected format for a coverity defect fix. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov> Closes openzfs#6777
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable commitcheck.sh to test if a commit message is
in the expected format for coverity defect fixes.
Motivation and Context
Automate commit message checking for coverity defect fixes.
How Has This Been Tested?
Locally on a RHEL 7 based system.
Types of changes
Checklist:
Signed-off-by.