Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update zfs module parameters man5 #6785

Merged
merged 3 commits into from Oct 30, 2017
Merged

Update zfs module parameters man5 #6785

merged 3 commits into from Oct 30, 2017

Conversation

abraunegg
Copy link
Contributor

@abraunegg abraunegg commented Oct 25, 2017 •
edited

Update zfs module parameters man5 with the following missing parameter
details:

  • zfs_arc_meta_strategy
  • Clarify with greater detail some existing options where the details of
    the options was not clear or the default value as previously detailed
    was incorrect as to what was actually the real default

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@abraunegg
Update zfs module parameters man5
2bfa801 
Update zfs module parameters man5 with the following missing parameter
details:
* zfs_arc_meta_strategy
Clarify with greater detail some existing options where the details of
the options was not clear or the default value as previously detailed
was incorrect as to what was actually the real default
dinatale2
dinatale2 suggested changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@dinatale2 dinatale2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abraunegg Thanks for the PR! I left you some inline comments about some inconsistencies I saw. Also, you need to a Signed-off-by line in your commit message. Thanks again!

@dinatale2 dinatale2 added the Type: Documentation Indicates a requested change to the documentation label Oct 27, 2017
@abraunegg
Update changes based on feedback
5bf09b5 
Update man5 changes based on feedback
@codecov
Copy link

codecov bot commented Oct 27, 2017 •
edited

Codecov Report

Merging #6785 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6785      +/-   ##
==========================================
+ Coverage   75.25%   75.32%   +0.07%     
==========================================
  Files         297      297              
  Lines       94374    94374              
==========================================
+ Hits        71021    71091      +70     
+ Misses      23353    23283      -70
Flag Coverage Δ
#kernel 74.77% <ø> (ø) ⬆️
#user 67.67% <ø> (+0.11%) ⬆️
Impacted Files Coverage Δ
module/zfs/zfs_rlock.c 90.98% <0%> (-5.33%) ⬇️
cmd/zed/agents/zfs_retire.c 77.63% <0%> (-1.87%) ⬇️
module/zfs/lzjb.c 98.14% <0%> (-1.86%) ⬇️
module/zfs/mmp.c 95.7% <0%> (-1.85%) ⬇️
module/zfs/dsl_userhold.c 88.49% <0%> (-1.2%) ⬇️
module/zfs/dmu_traverse.c 94.48% <0%> (-0.69%) ⬇️
module/zfs/zpl_file.c 90.38% <0%> (-0.39%) ⬇️
module/zfs/vdev.c 89.85% <0%> (-0.27%) ⬇️
module/zfs/zap_leaf.c 85.37% <0%> (-0.24%) ⬇️
module/zfs/vdev_raidz.c 97.83% <0%> (-0.23%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64b8c58...ed97c70. Read the comment docs.

@abraunegg
Add signed-off tag
ed97c70 
Add signed-off tag

Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
@behlendorf behlendorf merged commit ca85d69 into openzfs:master Oct 30, 2017
@behlendorf behlendorf added this to PR Needed for 0.7.4 in 0.7.4 Oct 30, 2017
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Nov 4, 2017
@abraunegg @Nasf-Fan
Update zfs module parameters man5
f2f3ae6 
Update zfs module parameters man5 with missing parameter details
for multiple tunings.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
Closes openzfs#6785
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Nov 6, 2017
@abraunegg @Nasf-Fan
Update zfs module parameters man5
0848282 
Update zfs module parameters man5 with missing parameter details
for multiple tunings.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
Closes openzfs#6785
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 21, 2017
@abraunegg @tonyhutter
Update zfs module parameters man5
246e515 
Update zfs module parameters man5 with missing parameter details
for multiple tunings.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
Closes openzfs#6785
@behlendorf behlendorf moved this from PR Needed for 0.7.4 to Merged to 0.7.4 in 0.7.4 Dec 12, 2017
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
@abraunegg @Nasf-Fan
Update zfs module parameters man5
fb8f222 
Update zfs module parameters man5 with missing parameter details
for multiple tunings.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
Closes openzfs#6785
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
@abraunegg @Nasf-Fan
Update zfs module parameters man5
fadd175 
Update zfs module parameters man5 with missing parameter details
for multiple tunings.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
Closes openzfs#6785
FransUrbo pushed a commit to FransUrbo/zfs that referenced this pull request Apr 28, 2019
@abraunegg @FransUrbo
Update zfs module parameters man5
7b05fb4 
Update zfs module parameters man5 with missing parameter details
for multiple tunings.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Alex Braunegg <alex.braunegg@gmail.com>
Closes openzfs#6785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gmelikov gmelikov gmelikov approved these changes

@dinatale2 dinatale2 dinatale2 approved these changes

Assignees
No one assigned
Labels
Type: Documentation Indicates a requested change to the documentation
Projects
No open projects
0.7.4
Merged to 0.7.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abraunegg @behlendorf @gmelikov @dinatale2