Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status command options in zpool(8) #6794

Merged
merged 1 commit into from Oct 27, 2017
Merged

Fix status command options in zpool(8) #6794

merged 1 commit into from Oct 27, 2017

Conversation

behlendorf
Copy link
Contributor

Description

The 'zpool status' command supports the -P option for printing full
path names. It does not support the -p parsable option for printing
exact values.

Motivation and Context

Issue #6792

How Has This Been Tested?

man man/man8/zpool.8

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@behlendorf
Fix status command options in zpool(8)
aee6f49 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
loli10K
loli10K approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@loli10K loli10K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test box had probably installed an old (pre-mandoc?) zpool manpage, i'm almost sure i saw -P mentioned when i added my comment in #6792: sorry about that.

gmelikov
gmelikov approved these changes Oct 27, 2017
View reviewed changes
Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@behlendorf behlendorf merged commit f4ae39a into openzfs:master Oct 27, 2017
scotws pushed a commit to scotws/zfs that referenced this pull request Oct 28, 2017
@behlendorf @scotws
Fix status command options in zpool(8)
90aa486 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.
    
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6792 
Closes openzfs#6794
@behlendorf behlendorf added this to PR Needed for 0.7.4 in 0.7.4 Oct 30, 2017
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Nov 4, 2017
@behlendorf @Nasf-Fan
Fix status command options in zpool(8)
b12eac0 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6792
Closes openzfs#6794
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Nov 6, 2017
@behlendorf @Nasf-Fan
Fix status command options in zpool(8)
2846624 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6792
Closes openzfs#6794
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 21, 2017
@behlendorf @tonyhutter
Fix status command options in zpool(8)
2d41e75 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.
    
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6792 
Closes openzfs#6794
@behlendorf behlendorf moved this from PR Needed for 0.7.4 to Merged to 0.7.4 in 0.7.4 Dec 12, 2017
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
@behlendorf @Nasf-Fan
Fix status command options in zpool(8)
beb971f 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6792
Closes openzfs#6794
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
@behlendorf @Nasf-Fan
Fix status command options in zpool(8)
67d61ef 
The 'zpool status' command supports the -P option for printing full
path names.  It does not support the -p parsable option for printing
exact values.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6792
Closes openzfs#6794
@behlendorf behlendorf deleted the issue-6792 branch April 19, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@loli10K loli10K loli10K approved these changes

@dinatale2 dinatale2 dinatale2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
0.7.4
Merged to 0.7.4
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@behlendorf @gmelikov @loli10K @dinatale2