Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zpool(8): Fix "zpool import -t" #6894

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Conversation

DeHackEd
Copy link
Contributor

Signed-off-by: DHE git@dehacked.net

Description

zpool import -t was accidentally relabeled as zpool import -s (duplicate for -s) during the mdoc conversion (cda0317)

Motivation and Context

Bad documentation

How Has This Been Tested?

Bisection to identify when it went bad

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

Signed-off-by: DHE <git@dehacked.net>
Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my bad!

@codecov
Copy link

codecov bot commented Nov 25, 2017

Codecov Report

Merging #6894 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6894      +/-   ##
==========================================
+ Coverage    75.1%   75.38%   +0.27%     
==========================================
  Files         298      298              
  Lines       95270    95270              
==========================================
+ Hits        71555    71817     +262     
+ Misses      23715    23453     -262
Flag Coverage Δ
#kernel 74.18% <ø> (-0.34%) ⬇️
#user 67.82% <ø> (+0.58%) ⬆️
Impacted Files Coverage Δ
module/zfs/zfs_rlock.c 90.16% <0%> (-5.74%) ⬇️
module/zfs/dsl_userhold.c 88.49% <0%> (-1.2%) ⬇️
module/icp/algs/edonr/edonr.c 43.45% <0%> (-0.94%) ⬇️
cmd/zed/agents/zfs_diagnosis.c 73.6% <0%> (-0.59%) ⬇️
module/zfs/dsl_scan.c 86.31% <0%> (-0.49%) ⬇️
module/zfs/zpl_file.c 90.38% <0%> (-0.39%) ⬇️
module/zfs/vdev_disk.c 70.81% <0%> (-0.36%) ⬇️
module/zfs/zfs_vfsops.c 78.12% <0%> (-0.13%) ⬇️
module/zfs/zap.c 65.81% <0%> (ø) ⬆️
lib/libzfs/libzfs_sendrecv.c 76.56% <0%> (+0.05%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94183a9...0007e5a. Read the comment docs.

@behlendorf behlendorf merged commit 1c68856 into openzfs:master Nov 28, 2017
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request Nov 28, 2017
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#6894
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request Dec 1, 2017
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#6894
tonyhutter pushed a commit that referenced this pull request Dec 5, 2017
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: DHE <git@dehacked.net>
Closes #6894
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 5, 2017
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#6894
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#6894
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: DHE <git@dehacked.net>
Closes openzfs#6894
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants