Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'zfs get {user|group}objused@' functionality #6908

Merged
merged 1 commit into from Nov 29, 2017
Merged

Fix 'zfs get {user|group}objused@' functionality #6908

merged 1 commit into from Nov 29, 2017

Conversation

loli10K
Copy link
Contributor

@loli10K loli10K commented Nov 29, 2017 •
edited

Description

Fix a regression accidentally introduced in 1b81ab4 that prevents zfs get {user|group}objused@ from correctly reporting the requested value.

Motivation and Context

Fix #6904

How Has This Been Tested?

Updated "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" scripts.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@loli10K
Fix 'zfs get {user|group}objused@' functionality
de21a4f 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
@openzfs openzfs deleted a comment from codecov bot Nov 29, 2017
behlendorf
behlendorf approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find. This LGTM as do the improved test cases. If you're happy with this as the final version I'll merge it.

@loli10K
Copy link
Contributor Author

loli10K commented Nov 29, 2017

@behlendorf thanks, i think this should be ready to merge.

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #6908 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6908      +/-   ##
==========================================
- Coverage   75.42%   75.22%   -0.21%     
==========================================
  Files         298      298              
  Lines       95270    95270              
==========================================
- Hits        71861    71668     -193     
- Misses      23409    23602     +193
Flag Coverage Δ
#kernel 74.42% <100%> (-0.41%) ⬇️
#user 67.45% <ø> (-0.41%) ⬇️
Impacted Files Coverage Δ
module/zfs/zfs_vfsops.c 78.37% <100%> (+0.24%) ⬆️
module/icp/algs/skein/skein_port.h 0% <0%> (-100%) ⬇️
module/zfs/ddt.c 91.03% <0%> (-5.92%) ⬇️
module/zfs/dmu_tx.c 81.27% <0%> (-4.59%) ⬇️
module/zfs/dsl_synctask.c 95.23% <0%> (-3.18%) ⬇️
cmd/zed/agents/zfs_retire.c 77.63% <0%> (-3.11%) ⬇️
cmd/zed/zed_disk_event.c 81.15% <0%> (-2.18%) ⬇️
cmd/zed/agents/fmd_api.c 86.47% <0%> (-2.14%) ⬇️
cmd/zed/agents/zfs_diagnosis.c 72.72% <0%> (-1.76%) ⬇️
module/zfs/mmp.c 95.7% <0%> (-1.23%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d8d8a...de21a4f. Read the comment docs.

@behlendorf behlendorf merged commit ed15d54 into openzfs:master Nov 29, 2017
@loli10K loli10K deleted the issue-6904 branch November 29, 2017 20:20
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request Nov 29, 2017
@loli10K @behlendorf
Fix 'zfs get {user|group}objused@' functionality
01be745 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#6908

Requires-spl: refs/pull/669/head
behlendorf pushed a commit to tonyhutter/zfs that referenced this pull request Dec 1, 2017
@loli10K @behlendorf
Fix 'zfs get {user|group}objused@' functionality
4ccc6c5 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#6908

Requires-spl: refs/pull/669/head
tonyhutter pushed a commit that referenced this pull request Dec 5, 2017
@loli10K @tonyhutter
Fix 'zfs get {user|group}objused@' functionality
6db8f1a 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #6908
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 5, 2017
@loli10K @tonyhutter
Fix 'zfs get {user|group}objused@' functionality
14d4551 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#6908
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Jan 29, 2018
@loli10K @Nasf-Fan
Fix 'zfs get {user|group}objused@' functionality
b309262 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#6908
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this pull request Feb 13, 2018
@loli10K @Nasf-Fan
Fix 'zfs get {user|group}objused@' functionality
ece3013 
Fix a regression accidentally introduced in 1b81ab4 that prevents
'zfs get {user|group}objused@' from correctly reporting the requested
value.

Update "userspace_003_pos.ksh" and "groupspace_003_pos.ksh" to verify
this functionality.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes openzfs#6908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@gmelikov gmelikov gmelikov approved these changes

@dinatale2 dinatale2 dinatale2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zfs get {user,group}objused@ always returns 0
4 participants
@loli10K @behlendorf @gmelikov @dinatale2